Fixing satquench model

[alexalar]

This PR fixes a bug in the implementation of the additional satellite quenching model.

Currently, if a halo is a central, the satellite quenching model should have no effect due to the values of the variables lgmu_infall,logmhost_infall,gyr_since_infall, for that halo. However, when the halo is a satellite, then the module incorrectly updates the quenched fraction probability of centrals, which will not be used because the halo is a satellite.

[aphearin]

We currently have one failing test: test_gradients_of_diffstarpop_pdf_satquench_params_are_nonzero. However, when I run this test locally on my laptop, it passes. Not sure what's going in here.

[alexalar]

I think this test should be failing with the update, because it computes the gradients for the mse loss of frac_quenc_cen, which now is no longer affected by satquench parameters. It should instead calculate now the mse loss of frac_quenc_sat. Let me correct it. It is strange if it wasn't failing for you locally.

[aphearin]

Great, that was going to be tedious for me to figure out - thanks for the quick fix! Looks like your most recent commit did the trick.

[aphearin]

However, when I run this test locally on my laptop, it passes. Not sure what's going in here.

Ohh and I just realized that when I tested this locally, I failed to check out the fixing_satquench branch, instead I incorrectly ran this test using the main branch. So it makes sense it it passed for me locally.