Skip to content

Add SIMULATION_FIT_PARAMS to top-level imports from diffstar.diffstarpop - #112

Merged
aphearin merged 2 commits into
mainfrom
param_convenience
May 6, 2026
Merged

Add SIMULATION_FIT_PARAMS to top-level imports from diffstar.diffstarpop#112
aphearin merged 2 commits into
mainfrom
param_convenience

Conversation

@aphearin

Copy link
Copy Markdown
Contributor

With this PR, you can now do this:

from diffstar.diffstarpop import SIMULATION_FIT_PARAMS
print(SIMULATION_FIT_PARAMS.keys()))

odict_keys(['smdpl_dr1_nomerging', 'smdpl_dr1', 'tng', 'galacticus_in_situ', 'galacticus_in_plus_ex_situ'])

Previously, you could only import this by drilling down into diffstarpop.kernels, and the dictionary had a very long and non-intuitive name (DiffstarPop_Params_Diffstarpopfits_mgash). I have not changed anything besides defining SIMULATION_FIT_PARAMS to be equal to this obscurely-named dictionary.

@aphearin aphearin assigned alexalar and unassigned alexalar Feb 20, 2026
@aphearin
aphearin requested a review from alexalar February 20, 2026 19:25
@aphearin
aphearin force-pushed the param_convenience branch from b134688 to 26a63b5 Compare May 6, 2026 15:15

@alexalar alexalar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, feel free to merge!

@aphearin
aphearin merged commit 69dc52d into main May 6, 2026
5 of 6 checks passed
@aphearin
aphearin deleted the param_convenience branch May 6, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants