Skip to content

Vehicle overview for Log Analysis - #1858

Open
OmkarSarkar204 wants to merge 4 commits into
ArduPilot:masterfrom
OmkarSarkar204:vehicle-overview
Open

Vehicle overview for Log Analysis#1858
OmkarSarkar204 wants to merge 4 commits into
ArduPilot:masterfrom
OmkarSarkar204:vehicle-overview

Conversation

@OmkarSarkar204

Copy link
Copy Markdown
Contributor

Description

Describe what this PR is trying to achieve. Please read our Contributing Guide for detailed guidelines.

Checklist

  • Run pre-commit checks locally
  • Verified by a human programmer
  • All commits are signed off (use git commit --signoff)
  • Code follows our coding standards
  • Documentation updated if needed
  • No breaking changes or properly documented

Testing

Describe how you tested these changes:

  • Unit tests pass
  • Integration tests pass
  • Manual testing performed
  • Tested on flight controller hardware

Copilot AI review requested due to automatic review settings July 28, 2026 06:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@OmkarSarkar204
OmkarSarkar204 marked this pull request as draft July 28, 2026 06:58
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30421805872

Coverage decreased (-0.7%) to 91.554%

Details

  • Coverage decreased (-0.7%) from the base build.
  • Patch coverage: Could not be determined — this PR's diff is too large for GitHub to return (406 error at GitHub).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 14966
Covered Lines: 13702
Line Coverage: 91.55%
Relevant Branches: 2310
Covered Branches: 2154
Branch Coverage: 93.25%
Branches in Coverage %: No
Coverage Strength: 2.74 hits per line

💛 - Coveralls

@amilcarlucas amilcarlucas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be greatly simplified, see the comments

Comment thread ardupilot_methodic_configurator/log_analysis/backend_vehicle_overview.py Outdated
Comment thread ardupilot_methodic_configurator/log_analysis/backend_vehicle_overview.py Outdated
Comment thread ardupilot_methodic_configurator/log_analysis/backend_vehicle_overview.py Outdated
@OmkarSarkar204
OmkarSarkar204 force-pushed the vehicle-overview branch 9 times, most recently from 58756b5 to 8eb718a Compare July 31, 2026 05:01
@OmkarSarkar204
OmkarSarkar204 marked this pull request as ready for review July 31, 2026 08:45
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
@amilcarlucas
amilcarlucas force-pushed the vehicle-overview branch 2 times, most recently from dd98a80 to 0c91b6f Compare August 1, 2026 03:44
…harden log parsing

split side-effecting loaders into data_sources.py
add shared log-analysis utilities/types in utils.py
remove ArduCopter hardcode by threading vehicle_type through backend_log_analysis.py
integrate PM validation into log summary output in backend_log_analysis.py
reduce duplicated field guards via base helper in data_model_quality_base.py
move shared param-value lookup usage to utility imports in backend_vehicle_overview.py and data_model_quality_esc.py
preserve firmware extraction behavior while decoupling imports in backend_firmware_version.py
fix pyright dynamic-attribute typing in backend_log_extraction.py
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants