mavproxy: allow 32 bit MAVLink system IDs - #1704
Open
tridge wants to merge 2 commits into
Open
Conversation
9 tasks
Lift the source_system and target_system setting ranges for MAVLink2.1 32 bit system IDs. The wire handling comes from pymavlink; targets in the extended TARGETTED header are overlaid onto decoded messages by pymavlink so vehicle switching and forwarding work unchanged.
the mission file has an 8 bit target_system field, so packing a target over 255 raised struct.error and aborted the upload for waypoints, fence and rally. The autopilot ignores that field when loading the file, so write zero as we do for other raw payload structs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lift the source_system and target_system setting ranges for MAVLink2.1 32 bit system IDs. The wire handling comes from pymavlink; targets in the extended TARGETTED header are overlaid onto decoded messages by pymavlink so vehicle switching and forwarding work unchanged.
Requires ArduPilot/pymavlink#1229