Skip to content

fix(pr-contract): relax marker prose guard#91

Merged
ArchonVII merged 1 commit into
mainfrom
agent/codex/90-pr-contract-placeholder-matching
Jun 20, 2026
Merged

fix(pr-contract): relax marker prose guard#91
ArchonVII merged 1 commit into
mainfrom
agent/codex/90-pr-contract-placeholder-matching

Conversation

@ArchonVII

@ArchonVII ArchonVII commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • Loosens the shared PR contract marker detector so normal completed prose is not rejected for a legitimate word that used to be treated as a banned token.
  • Keeps explicit unfinished markers rejected while preserving the existing ready-for-review structure checks, including literal filler values made only from the marker word.

Verification

  • npx vitest run scripts/pr-contract.test.mjs
command: npx vitest run scripts/pr-contract.test.mjs
location: local
result: passed; 23 tests
timestamp: 2026-06-20T19:00:54Z
  • git diff --check
command: git diff --check
location: local
result: exit 0; CRLF warnings only
timestamp: 2026-06-20T19:00:54Z

Verification Notes

Full local npm test on Windows stopped while importing unchanged scripts/doc-policy-lint.test.mjs with SyntaxError: Invalid or unexpected token. Recent upstream Self-test (scripts) on main passed in GitHub Actions run 27698751593, and this PR should use the PR self-test for the Linux full-suite signal. The automated review thread was addressed by adding literal-filler rejection tests.

Docs / Changelog

Added a changelog fragment and a repository update log entry.

Plan/status artifacts: none created or used by this lane.

Linked Issue

Closes #90

Risks

  • Risk level: Low; this narrows one marker detector token while preserving unfinished marker rejection.
  • Rollback: Revert this commit to restore the previous marker token list.
  • Follow-ups: Move v1 after merge.

@ArchonVII
ArchonVII force-pushed the agent/codex/90-pr-contract-placeholder-matching branch from 9ce8229 to 2c38fd5 Compare June 20, 2026 18:36
@ArchonVII
ArchonVII marked this pull request as ready for review June 20, 2026 18:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c38fd5e5c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/pr-contract.mjs
@ArchonVII
ArchonVII force-pushed the agent/codex/90-pr-contract-placeholder-matching branch from 2c38fd5 to c440401 Compare June 20, 2026 19:00
Remove the standalone placeholder token from the PR contract detector so completed prose can mention placeholder matching without blocking ready-for-review.

Explicit unfilled markers remain rejected by the same scanner.

Refs #90
@ArchonVII
ArchonVII force-pushed the agent/codex/90-pr-contract-placeholder-matching branch from c440401 to 2402650 Compare June 20, 2026 19:01
@ArchonVII
ArchonVII merged commit a76183f into main Jun 20, 2026
1 check passed
@ArchonVII
ArchonVII deleted the agent/codex/90-pr-contract-placeholder-matching branch June 20, 2026 19:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2402650491

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/pr-contract.mjs
Comment on lines +417 to +418
words.every((word) => word === 'placeholder')
|| words.join(' ') === 'placeholder text'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject explicit placeholder prose beyond bare filler

When a generated body leaves text such as This is a placeholder for the summary in ## Summary, ### Verification Notes, or ## Docs / Changelog, this helper no longer treats it as a placeholder because it only rejects lines whose words are all placeholder or exactly placeholder text; hasSubstantiveContent() then sees enough characters and the non-doc PR passes the ready-for-review contract. This is a fresh scenario beyond the earlier bare placeholder placeholder placeholder case, and it regresses explicit placeholder filler that the contract still says must be removed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loosen PR contract placeholder matching

1 participant