fix(pr-contract): relax marker prose guard#91
Conversation
9ce8229 to
2c38fd5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c38fd5e5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2c38fd5 to
c440401
Compare
Remove the standalone placeholder token from the PR contract detector so completed prose can mention placeholder matching without blocking ready-for-review. Explicit unfilled markers remain rejected by the same scanner. Refs #90
c440401 to
2402650
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2402650491
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| words.every((word) => word === 'placeholder') | ||
| || words.join(' ') === 'placeholder text' |
There was a problem hiding this comment.
Reject explicit placeholder prose beyond bare filler
When a generated body leaves text such as This is a placeholder for the summary in ## Summary, ### Verification Notes, or ## Docs / Changelog, this helper no longer treats it as a placeholder because it only rejects lines whose words are all placeholder or exactly placeholder text; hasSubstantiveContent() then sees enough characters and the non-doc PR passes the ready-for-review contract. This is a fresh scenario beyond the earlier bare placeholder placeholder placeholder case, and it regresses explicit placeholder filler that the contract still says must be removed.
Useful? React with 👍 / 👎.
Summary
Verification
npx vitest run scripts/pr-contract.test.mjsgit diff --checkVerification Notes
Full local
npm teston Windows stopped while importing unchangedscripts/doc-policy-lint.test.mjswithSyntaxError: Invalid or unexpected token. Recent upstreamSelf-test (scripts)onmainpassed in GitHub Actions run 27698751593, and this PR should use the PR self-test for the Linux full-suite signal. The automated review thread was addressed by adding literal-filler rejection tests.Docs / Changelog
Added a changelog fragment and a repository update log entry.
Plan/status artifacts: none created or used by this lane.
Linked Issue
Closes #90
Risks
v1after merge.