fix(gate): accept plural required check maps#117
Merged
Conversation
ArchonVII
marked this pull request as ready for review
July 19, 2026 01:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
required_gateslists and legacy singularrequired_gatemappings while requiring unique, non-empty string check names, including valid plain names with embedded quote characters.Verification
npx vitest run scripts/validate-check-map.test.mjs scripts/workflow-structure.test.mjs— 86 passed, 0 failed.npm test— 244 passed, 0 failed across 10 files.C:\Users\josep\go\bin\actionlint.exe .github\workflows\repo-required-gate.yml— exited 0.node --checkon all touched.mjsfiles — exited 0.Validator CLI runs accepted both this repository's legacy singular map and repo-template PR #187's plural map.
git diff origin/agent/codex/116-plural-required-gates..HEAD --check— exited 0.Verification Notes
The implementation completed independent specification re-review (
Spec compliant) and bounded code-quality review (Approved). The embedded-quote P1 was reproduced test-first as 4 failed / 58 passed, then repaired at the quote-state boundary; plural and legacy cases forteam's / gateand6" screen / gatenow pass. Regression coverage also includes canonical multi-check plural lists, legacy singular maps, arbitrary custom names, absent optional maps, and the malformed forms named in issue #116's acceptance criteria.Docs / Changelog
Updated
.changelog/unreleased/116-plural-required-gates.mdanddocs/repo-update-log.mdwith the embedded-quote compatibility repair, verification, and pendingv1propagation.Plan/status artifacts: issue #116 is the canonical task record and remains open until merge; no repo-facing plan or status file was created or used by this lane.
Owner decisions this lane: none.
Linked Issue
Closes #116
Risks
197d9c9and8335d15to restore the singular-only inline validation.v1tag must advance beforeArchonVII/repo-templatePR #187 can rerun against the repaired shared validator.