fix(agent): refresh durable carry baseline#392
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
archon-setup/scripts/agent/carry.mjs
Line 90 in ff62c14
When a carried directory has a non-default mode (for example chmod 700 secrets/), this recursive copy creates the destination directory with the process umask rather than the source mode, while buildPathManifest now includes directory mode; the immediate receipt check then reports destination worktree changed and agent:start-task --carry secrets aborts without carrying an otherwise valid task input. Please chmod copied directories to the captured modes, or avoid comparing directory modes, before verification.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
e413928c0d029b8d6f0d718b64ea939fe5033fbe.Verification
node --test test/agentSelfApply.test.mjs test/writeAgentLifecycle.test.mjs test/refreshSnapshots.test.mjs test/agentLifecycleScripts.test.mjs test/globalUpdates.test.mjsnpm run snapshots:verifynpm run agent:self-apply -- --checknode --test src/snapshots/repo-template/test/agent/carry.test.mjson Windows and WSL/Linuxnpm testnode --test test/ecosystemOverview.test.mjsnpm run docs:render -- --checknode scripts/doc-health/health.mjs --repo . --jsongit diff --checkVerification Notes
The provider range
efeba25..e413928contains exactly repo-template PRs #210 and #212. The latter is the bounded correction required by GitHub Codex's directory-mode finding on the first Archon candidate; no unrelated provider commits are included. GitHub CI and a fresh exact-head Codex review will validate the complete pushed head before merge.Docs / Changelog
Updated the existing canonical status, catalog, README, and ecosystem records, regenerated the ecosystem overview, and added
.changelog/unreleased/391-durable-carry-provider-refresh.md.Plan/status artifacts: no standalone plan artifact was created; issue #391 is the canonical bounded plan and this PR will update the existing current-work/status homes.
Linked Issue
Closes #391
Risks