Conversation
duckboycool
left a comment
There was a problem hiding this comment.
Feedback of descending importance.
| #PORT: 80 | ||
|
|
||
| # Public URL used to construct endpoints for game clients connecting to webhost'd multiservers | ||
| #PUBLIC_URL: https://archipelago.gg |
There was a problem hiding this comment.
This (for good reason) isn't actually the default value like the comment at the top of here says. Using it as an example would probably be better in the comment above.
(Also HOST_ADDRESS gets this wrong currently as well I guess...)
There was a problem hiding this comment.
Fixed the value to be null, and reworded the comments around it to be more clear about how it's used.
It might be worth defaulting this to http://localhost for people doing apworld development that want to test against it? Unsure.
duckboycool
left a comment
There was a problem hiding this comment.
Worked as expected from MultiServer, from WebHost without a URL set, and with one. I think maybe the default should be to match to HOST_ADDRESS (I guess with a value like "" to distinguish from specifically opting out with null?), but I'll leave that up to other reviewers.
What is this fixing or adding?
Adds an optional
datapackage_urlto RoomInfo to allow game clients to use HTTP requests to retrieve datapackages instead of using GetDataPackage commands.PUBLIC_URLhas been added to the app config, anddatapackage_urlis built insideget_static_server_data()for rooms using WebHost's customserverThis should help:
How was this tested?
For a local server, add
PUBLIC_URL: http://localhostto app configHost a room through the webhost.
Get the datapackage checksum from the RoomInfo message
Append
/<checksum>to thedatapackage_urlin RoomInfo and confirm you can retrieve from this url in a browser