Core: Add message to world AttributeError - #6441
Open
duckboycool wants to merge 1 commit into
Open
duckboycool wants to merge 1 commit into
duckboycool wants to merge 1 commit into
Conversation
github-actions
Bot
added
affects: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
I've seen this bare "AttributeError" a few times now when users send logs, so it'd probably be good for it to give an actual descriptive message.
There's also some other instances of this with
MemoryErrorandNotImplementedError(which I guess are fine, although the latter instances should maybe use abstract methods instead) and then a few with other error types in worlds.How was this tested?
Running gen with a bad attribute access in a world to verify the message.
If this makes graphical changes, please attach screenshots.
🗣️