Skip to content

SC2: Content update - #5312

Merged
Berserker66 merged 1520 commits into
ArchipelagoMW:mainfrom
Ziktofel:sc2-next
Sep 2, 2025
Merged

SC2: Content update#5312
Berserker66 merged 1520 commits into
ArchipelagoMW:mainfrom
Ziktofel:sc2-next

Conversation

@Ziktofel

@Ziktofel Ziktofel commented Aug 11, 2025

Copy link
Copy Markdown
Collaborator

What is this fixing or adding?

Feature highlights:

  • Adds many content to the SC2 game
  • Allows custom mission order
  • Adds race-swapped missions for build missions (except Epilogue and NCO)
  • Allows War Council Nerfs (Protoss units can get pre - War Council State, alternative units get another custom nerf to match the power level of base units)
  • Revamps Predator's upgrade tree (never was considered strategically important)
  • Adds some units and upgrades
  • Locked and excluded items can specify quantity
  • Key mode (if opt-in, missions require keys to be unlocked on top of their regular regular requirements
  • Victory caches - Victory locations can grant multiple items to the multiworld instead of one
  • The generator is more resilient for generator failures as it validates logic for item excludes
  • Fixes the following issues:

How was this tested?

  • Test async game
  • Verification run (over all the game's content) to spot the bugs, so all the checks work
  • Unit tests

If this makes graphical changes, please attach screenshots.

  • Client got simplified, dropped unneeded tabs:
Snímek obrazovky pořízený 2025-08-11 20-33-07 - Tracker redesign (more dynamically generated with item descriptions as tooltips): Snímek obrazovky pořízený 2025-08-11 20-34-07

Comment thread worlds/sc2/__init__.py Outdated
"""Locations locked to contain specific items, such as victory events or forced resources"""
location_cache: List[Location]
final_missions: List[int]
required_client_version = 0, 6, 3

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be 0.6.4 by now.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bumped

@Ziktofel
Ziktofel requested a review from Berserker66 August 25, 2025 20:19
Comment thread worlds/sc2/client.py
if self.ui:
self.ui.first_check = True

def is_legacy_game(self):

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it actually still support the WOL only campaign? Has anyone tested that?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the support for games < 0.4.5 that got kept with the release. How's the support length schedule?

@Berserker66 Berserker66 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the code, didn't find any new security issues. Played a couple rounds. Found a bug that was already fixed and a couple oddities that were explained. Sadly the existing security issue of very old protobuf is not fixed with this, so everyone, including me, who is subscribed to security notifications for the AP repo will continue to get spammed weekly.

My personal grievance that /received is overwritten also remains.

@Berserker66
Berserker66 merged commit 5f1835c into ArchipelagoMW:main Sep 2, 2025
21 checks passed
@Ziktofel

Ziktofel commented Sep 2, 2025

Copy link
Copy Markdown
Collaborator Author

I plan to address the protobuf issue in the next dev cycle. It's on the priority list. I plan the SC2's next dev cycle to be mainly maintenance in order to fix those issues

eternalcode0 pushed a commit to eternalcode0/Archipelago that referenced this pull request Dec 20, 2025
Feature highlights:
- Adds many content to the SC2 game
- Allows custom mission order
- Adds race-swapped missions for build missions (except Epilogue and NCO)
- Allows War Council Nerfs (Protoss units can get pre - War Council State, alternative units get another custom nerf to match the power level of base units)
- Revamps Predator's upgrade tree (never was considered strategically important)
- Adds some units and upgrades
- Locked and excluded items can specify quantity
- Key mode (if opt-in, missions require keys to be unlocked on top of their regular regular requirements
- Victory caches - Victory locations can grant multiple items to the multiworld instead of one 
- The generator is more resilient for generator failures as it validates logic for item excludes
- Fixes the following issues:
  - ArchipelagoMW#3531 
  - ArchipelagoMW#3548
eternalcode0 pushed a commit to eternalcode0/Archipelago that referenced this pull request Dec 21, 2025
Feature highlights:
- Adds many content to the SC2 game
- Allows custom mission order
- Adds race-swapped missions for build missions (except Epilogue and NCO)
- Allows War Council Nerfs (Protoss units can get pre - War Council State, alternative units get another custom nerf to match the power level of base units)
- Revamps Predator's upgrade tree (never was considered strategically important)
- Adds some units and upgrades
- Locked and excluded items can specify quantity
- Key mode (if opt-in, missions require keys to be unlocked on top of their regular regular requirements
- Victory caches - Victory locations can grant multiple items to the multiworld instead of one 
- The generator is more resilient for generator failures as it validates logic for item excludes
- Fixes the following issues:
  - ArchipelagoMW#3531 
  - ArchipelagoMW#3548
wcoldren pushed a commit to wcoldren/Archipelago that referenced this pull request Jun 18, 2026
Feature highlights:
- Adds many content to the SC2 game
- Allows custom mission order
- Adds race-swapped missions for build missions (except Epilogue and NCO)
- Allows War Council Nerfs (Protoss units can get pre - War Council State, alternative units get another custom nerf to match the power level of base units)
- Revamps Predator's upgrade tree (never was considered strategically important)
- Adds some units and upgrades
- Locked and excluded items can specify quantity
- Key mode (if opt-in, missions require keys to be unlocked on top of their regular regular requirements
- Victory caches - Victory locations can grant multiple items to the multiworld instead of one 
- The generator is more resilient for generator failures as it validates logic for item excludes
- Fixes the following issues:
  - ArchipelagoMW#3531 
  - ArchipelagoMW#3548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects: core Issues/PRs that touch core and may need additional validation. affects: webhost Issues/PRs that touch webhost and may need additional validation. is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. is: enhancement Issues requesting new features or pull requests implementing new features. is: refactor/cleanup Improvements to code/output readability or organizization. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.