Skip to content

[Tweak] Resprite (-mag) states for Lecter & Drozd#32

Open
UmbiMax wants to merge 2 commits into
ArcaneSS14:arcane-devfrom
UmbiMax:Sprites-Bugfif
Open

[Tweak] Resprite (-mag) states for Lecter & Drozd#32
UmbiMax wants to merge 2 commits into
ArcaneSS14:arcane-devfrom
UmbiMax:Sprites-Bugfif

Conversation

@UmbiMax

@UmbiMax UmbiMax commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Описание PR

Ещё 25 минут в урну из-за переноса.

Медиа

Тип PR

  • Feature
  • Fix
  • Tweak
  • Balance
  • Refactor
  • Port
  • Translate
  • Resprite

Лицензионное соглашение

  • Я согласен с лицензионным соглашением Contributor License Agreement, для Arcane14 Organization.

Изменения

🆑

  • tweak: Респрайт слоёв магазинов у лектера и дрозда.

Summary by CodeRabbit

  • Chores
    • Updated attribution metadata for magazine-state artwork.
    • Simplified magazine-state animation metadata for select rifle and SMG assets.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

RSI Diff Bot; head commit 3c086e2 merging into 3eab969
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi

State Old New Status
base Modified
mag-0 Modified
mag-1 Modified
mag-2 Modified
mag-3 Modified
mag-4 Modified

Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi

State Old New Status
mag-0 Modified
mag-1 Modified
mag-2 Modified
mag-3 Modified
mag-4 Modified

Edit: diff updated after 3c086e2

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f88dcd4-b0da-45d8-8ddf-56cc81e1f93f

📥 Commits

Reviewing files that changed from the base of the PR and between 22bd555 and f3af9ba.

⛔ Files ignored due to path filters (11)
  • Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/base.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/mag-0.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/mag-1.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/mag-2.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/mag-3.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/mag-4.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi/mag-0.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi/mag-1.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi/mag-2.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi/mag-3.png is excluded by !**/*.png
  • Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi/mag-4.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/meta.json
  • Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi/meta.json

📝 Walkthrough

Walkthrough

Updated magazine-state attribution and removed delays blocks from the mag-1 through mag-4 states in the Lecter and Drozd weapon sprite metadata.

Changes

Magazine State Metadata

Layer / File(s) Summary
Magazine state definitions and attribution
Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/meta.json, Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi/meta.json
Updated magazine-state contributor attribution and removed timing arrays from the mag-1 through mag-4 state entries.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: size/M

Suggested reviewers: vecortys

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: respriting the magazine states for Lecter and Drozd.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
Resources/Textures/Objects/Weapons/Guns/Rifles/lecter.rsi/meta.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

Resources/Textures/Objects/Weapons/Guns/SMGs/drozd.rsi/meta.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant