Янтарный Код и звуки анонсов Ориона#22
Conversation
Улучшение UI - сначала идут "боевые" коды, потом дополнительные
📝 WalkthroughWalkthroughAdds Arcane amber alert configuration, localization, screen state data, alert color/order updates, and licensing attribution for announcement audio. ChangesArcane alert levels
Audio licensing
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Screen пока что отображает заглушку от кода Омега. Картинка в производстве |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Audio/_Orion/Announcements/licenses.txt`:
- Line 1: Add a trailing newline to the end of the license attribution in
licenses.txt, without changing its existing text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1ec0a7a1-7cef-4590-ae53-d86217ed2527
⛔ Files ignored due to path filters (14)
Resources/Audio/_Orion/Announcements/2_tone_alarm.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/alien.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/angry.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/announce.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/beep_beep.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/blusp_anomalies.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/centcomm.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/comms_blackout.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/crashing.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/crew_s_called.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/flux.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/ionstorm.oggis excluded by!**/*.oggResources/Audio/_Orion/Announcements/overload.oggis excluded by!**/*.oggResources/Textures/Structures/Wallmounts/screen.rsi/amber.pngis excluded by!**/*.png
📒 Files selected for processing (4)
Resources/Audio/_Orion/Announcements/licenses.txtResources/Locale/ru-RU/alert-levels/alert-levels.ftlResources/Prototypes/AlertLevels/alert_levels.ymlResources/Textures/Structures/Wallmounts/screen.rsi/meta.json
| @@ -0,0 +1 @@ | |||
| All sounds in this folder are taken from TauCeti GitHub (licensed under CC-BY-SA by 3.0) at commit https://github.com/TauCetiStation/TauCetiClassic/commit/92d2767dbb39f28540f78d5055e7be1eb7acee98 No newline at end of file | |||
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add a final newline.
Both EditorConfig checks fail because this file does not end with a newline.
Proposed fix
All sounds in this folder are taken from TauCeti GitHub (licensed under CC-BY-SA by 3.0) at commit https://github.com/TauCetiStation/TauCetiClassic/commit/92d2767dbb39f28540f78d5055e7be1eb7acee98
+📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| All sounds in this folder are taken from TauCeti GitHub (licensed under CC-BY-SA by 3.0) at commit https://github.com/TauCetiStation/TauCetiClassic/commit/92d2767dbb39f28540f78d5055e7be1eb7acee98 | |
| All sounds in this folder are taken from TauCeti GitHub (licensed under CC-BY-SA by 3.0) at commit https://github.com/TauCetiStation/TauCetiClassic/commit/92d2767dbb39f28540f78d5055e7be1eb7acee98 | |
🧰 Tools
🪛 GitHub Actions: EditorConfig Check / 0_EditorConfig Check.txt
[error] 1-1: check_crlf.py failed: The file does not end with a newline. Please add a final newline.
🪛 GitHub Actions: EditorConfig Check / EditorConfig Check
[error] 1-1: CRLF check failed: The file does not end with a newline. Please add a final newline.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Resources/Audio/_Orion/Announcements/licenses.txt` at line 1, Add a trailing
newline to the end of the license attribution in licenses.txt, without changing
its existing text.
Source: Pipeline failures
|
Не |
|
Нам не нужны старые звуки оповещений. Текущие вполне удовлетворительные |
|
Часть прекрасных звуков сам перенесу да доработаю в AU. |

Описание PR
Медиа
Чек-лист
Тип PR
Лицензионное соглашение
Изменения
🆑 Don
Summary by CodeRabbit