Skip to content

Янтарный Код и звуки анонсов Ориона#22

Open
devnopay wants to merge 3 commits into
ArcaneSS14:arcane-devfrom
devnopay:ComputerComms
Open

Янтарный Код и звуки анонсов Ориона#22
devnopay wants to merge 3 commits into
ArcaneSS14:arcane-devfrom
devnopay:ComputerComms

Conversation

@devnopay

@devnopay devnopay commented Jul 19, 2026

Copy link
Copy Markdown

Описание PR

Медиа

Снимок экрана 2026-07-19 045847 Снимок экрана 2026-07-19 045814

Чек-лист

  • Картинка для экрана

Тип PR

  • Feature
  • Fix
  • Tweak
  • Balance
  • Refactor
  • Port
  • Translate
  • Resprite

Лицензионное соглашение

  • Я согласен с лицензионным соглашением Contributor License Agreement, для Arcane14 Organization.

Изменения

🆑 Don

  • add: Загружены звуки анонсов Ориона. Пока что применяется только один.
  • add: Янтарный Код - промежуточный между Синим и Красным
  • fix: Изменен цвет Оранжевого Кода, что бы он не конфликтовал с Янтарным
  • fix: Улучшение UI консоли кодов - теперь сверху находятся "боевые" коды, а снизу "технические"

Summary by CodeRabbit

  • New Features
    • Added support for the amber station alert level, including localized announcements and instructions.
    • Added an amber visual state for wall-mounted screens.
  • Improvements
    • Updated alert-level ordering and color presentation for clearer Arcane/UI displays.
    • Refined orange alert coloring for improved visual distinction.
  • Documentation
    • Added licensing attribution for announcement audio assets.

devnopay added 2 commits July 19, 2026 04:28
Улучшение UI - сначала идут "боевые" коды, потом дополнительные
@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

RSI Diff Bot; head commit 77446ba merging into 4cf4ab9
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Wallmounts/screen.rsi

State Old New Status
amber Added

Edit: diff updated after 77446ba

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds Arcane amber alert configuration, localization, screen state data, alert color/order updates, and licensing attribution for announcement audio.

Changes

Arcane alert levels

Layer / File(s) Summary
Alert level configuration and assets
Resources/Prototypes/AlertLevels/alert_levels.yml, Resources/Locale/ru-RU/alert-levels/alert-levels.ftl, Resources/Textures/Structures/Wallmounts/screen.rsi/meta.json
Reorders and updates amber and red definitions, changes orange colors, adds Russian amber strings, and registers the amber screen state.

Audio licensing

Layer / File(s) Summary
Announcement audio attribution
Resources/Audio/_Orion/Announcements/licenses.txt
Adds TauCeti GitHub source and CC-BY-SA 3.0 attribution for the announcement sounds.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: adding the Amber code and porting Orion announcement sounds.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devnopay

Copy link
Copy Markdown
Author

Screen пока что отображает заглушку от кода Омега. Картинка в производстве

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Resources/Audio/_Orion/Announcements/licenses.txt`:
- Line 1: Add a trailing newline to the end of the license attribution in
licenses.txt, without changing its existing text.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1ec0a7a1-7cef-4590-ae53-d86217ed2527

📥 Commits

Reviewing files that changed from the base of the PR and between 4cf4ab9 and 69d4055.

⛔ Files ignored due to path filters (14)
  • Resources/Audio/_Orion/Announcements/2_tone_alarm.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/alien.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/angry.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/announce.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/beep_beep.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/blusp_anomalies.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/centcomm.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/comms_blackout.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/crashing.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/crew_s_called.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/flux.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/ionstorm.ogg is excluded by !**/*.ogg
  • Resources/Audio/_Orion/Announcements/overload.ogg is excluded by !**/*.ogg
  • Resources/Textures/Structures/Wallmounts/screen.rsi/amber.png is excluded by !**/*.png
📒 Files selected for processing (4)
  • Resources/Audio/_Orion/Announcements/licenses.txt
  • Resources/Locale/ru-RU/alert-levels/alert-levels.ftl
  • Resources/Prototypes/AlertLevels/alert_levels.yml
  • Resources/Textures/Structures/Wallmounts/screen.rsi/meta.json

@@ -0,0 +1 @@
All sounds in this folder are taken from TauCeti GitHub (licensed under CC-BY-SA by 3.0) at commit https://github.com/TauCetiStation/TauCetiClassic/commit/92d2767dbb39f28540f78d5055e7be1eb7acee98 No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add a final newline.

Both EditorConfig checks fail because this file does not end with a newline.

Proposed fix
 All sounds in this folder are taken from TauCeti GitHub (licensed under CC-BY-SA by 3.0) at commit https://github.com/TauCetiStation/TauCetiClassic/commit/92d2767dbb39f28540f78d5055e7be1eb7acee98
+
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
All sounds in this folder are taken from TauCeti GitHub (licensed under CC-BY-SA by 3.0) at commit https://github.com/TauCetiStation/TauCetiClassic/commit/92d2767dbb39f28540f78d5055e7be1eb7acee98
All sounds in this folder are taken from TauCeti GitHub (licensed under CC-BY-SA by 3.0) at commit https://github.com/TauCetiStation/TauCetiClassic/commit/92d2767dbb39f28540f78d5055e7be1eb7acee98
🧰 Tools
🪛 GitHub Actions: EditorConfig Check / 0_EditorConfig Check.txt

[error] 1-1: check_crlf.py failed: The file does not end with a newline. Please add a final newline.

🪛 GitHub Actions: EditorConfig Check / EditorConfig Check

[error] 1-1: CRLF check failed: The file does not end with a newline. Please add a final newline.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Resources/Audio/_Orion/Announcements/licenses.txt` at line 1, Add a trailing
newline to the end of the license attribution in licenses.txt, without changing
its existing text.

Source: Pipeline failures

@UmbiMax

UmbiMax commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Не #Arcane, а # Arcane.

@Vecortys

Copy link
Copy Markdown
Contributor

Нам не нужны старые звуки оповещений. Текущие вполне удовлетворительные

@UmbiMax

UmbiMax commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Часть прекрасных звуков сам перенесу да доработаю в AU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants