fix: attach SLSA provenance bundle to release - #50
Conversation
The plugin validator runs in an isolated environment that cannot query the GitHub attestations API or Sigstore. Attaching the in-toto bundle as a release asset (alongside the zip) lets the validator verify provenance locally and satisfies the no-provenance-attestation recommendation. Bumps to 1.0.0-beta.3 for resubmission.
There was a problem hiding this comment.
Code Review
This pull request updates the version to 1.0.0-beta.3 and adds a corresponding entry to the changelog regarding SLSA provenance. Feedback indicates that the functional changes to the build workflow mentioned in the description are missing from the current diff and should be included.
| { | ||
| "name": "arcadedb-arcadedb-datasource", | ||
| "version": "1.0.0-beta.2", | ||
| "version": "1.0.0-beta.3", |
There was a problem hiding this comment.
The pull request description mentions functional changes to the build workflow, such as capturing the SLSA provenance bundle and adding it to the release assets. However, these changes are not present in the current diff, which only includes the version bump and changelog update. Please include the relevant workflow files (e.g., .github/workflows/release.yml) to complete the implementation.
Summary
The catalog re-review of
v1.0.0-beta.2cleared the package.json/plugin.json mismatch but still emits:Our
actions/attest-build-provenancestep is producing a valid SLSA v1 bundle (verifiable locally withgh attestation verify), but the validator runs in an environment that can't reach the GitHub attestations API or Sigstore to discover it. Attaching the in-toto bundle as a release asset lets the validator verify the zip's provenance from a local file.Changes
attest-build-provenanceand rename it to<zip>.intoto.jsonlnext to the zip..intoto.jsonlto both the GitHub releasefiles:and the workflow artifactpath:.package.jsonto1.0.0-beta.3.Note
This is a 💡 recommendation, not a ❌ blocker, in the validator output. The previous release was technically eligible for review with this hint outstanding. Fixing it now to keep the listing clean.
After merge
git checkout main && git pull git tag v1.0.0-beta.3 git push origin v1.0.0-beta.3Then update grafana.com ticket #228429 with the new zip/sha1 URLs.
Test plan
package.jsonparsesv1.0.0-beta.3produces a release with.zip,.sha1, and.intoto.jsonlassets