feat: potential changes to the sc election - #315
Open
yahgwai wants to merge 128 commits into
Open
Conversation
godzillaba
reviewed
Sep 30, 2024
yahgwai
marked this pull request as ready for review
October 2, 2024 11:20
gzeoneth
requested changes
Oct 3, 2024
godzillaba
reviewed
Oct 3, 2024
* feat: setCadence * test: setCadence * chore: update misc * test: 36 months * feat: CadenceChanged event * refactor: move CadenceChanged to Timing abstract contract * update optimizer runs * refactor: cut some size * refactor: equal 0 * fix: return * docs: currentElectionCount * refactor: use solady add and subMonths * chore: reduce sec_council_mgmt opt-run to 500 due to contract size * chore: cleanup lint warning * Simple cadence minor fixes (#359) --------- Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com> Co-authored-by: José FP <105675159+TucksonDev@users.noreply.github.com>
* feat: setCadence * test: setCadence * chore: update misc * test: 36 months * feat: CadenceChanged event * refactor: move CadenceChanged to Timing abstract contract * update optimizer runs * refactor: cut some size * refactor: equal 0 * fix: return * docs: currentElectionCount * refactor: use solady add and subMonths * chore: reduce sec_council_mgmt opt-run to 500 due to contract size * refactor: rename to SecurityCouncilUpgradeAction * feat: SecurityCouncilUpgradeAction * chore: cleanup lint warning * chore: storage * chore: 4bytes * feat: more validations --------- Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
* feat: setCadence * test: setCadence * chore: update misc * test: 36 months * feat: CadenceChanged event * refactor: move CadenceChanged to Timing abstract contract * update optimizer runs * refactor: cut some size * refactor: equal 0 * fix: return * docs: currentElectionCount * refactor: use solady add and subMonths * chore: reduce sec_council_mgmt opt-run to 500 due to contract size * refactor: rename to SecurityCouncilUpgradeAction * feat: SecurityCouncilUpgradeAction * chore: cleanup lint warning * chore: storage * chore: 4bytes * feat: more validations * revert: rotatingTo * feat: rotateNominee * chore: contract size reduction * refactor: use isCompliantNominee * fix: wrong sign * fix: rotationDeadline * test: rotateNominee * review fixes for "feat: rotateNominee" (#360) * misc review fixes * fix gas and sigs --------- Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
feat: more change to security council election
gzeoneth
changed the title
* fix: prevent duplicate members * feat: _requireNotInOtherCohort * test: cannot rotate to existing nominee * chore: update gas snapshot * fix: check new nominee address excluded * chore: update gas snapshot for new foundry version * mark _requireNotInOtherCohort as view and fix comment --------- Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
* fix: prevent duplicate members * feat: _requireNotInOtherCohort * test: cannot rotate to existing nominee * chore: update gas snapshot * fix: check new nominee address excluded * chore: update gas snapshot for new foundry version * mark _requireNotInOtherCohort as view and fix comment * Remove nominee bypass * Fix merge * Fix merged snapshots * Update expected election counter and comments * Fix tests * Add payload * Fix nominee rotation * Add new proposal data * Fix gas snapshot --------- Co-authored-by: gzeon <im@gzeon.dev> Co-authored-by: Henry <11198460+godzillaba@users.noreply.github.com>
gzeoneth
self-requested a review
July 27, 2026 10:28
Collaborator
|
CI passed on #380 but failing here due to foundry version, need to repin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security Council election-process improvements ratified in the constitutional AIP.
Forum: https://forum.arbitrum.foundation/t/constitutional-aip-ratification-of-security-council-election-process-improvements/31048
Changes:
Pre-deployed implementations, the SecurityCouncilUpgradeAction, and the proposal payload are in #380