ci: name updater artifacts uniquely; pick them explicitly - #46
Merged
Conversation
Two latest.json bugs: both macOS arches emit PyOps.app.tar.gz (no arch) so they clobber each other on upload, and Linux signs both the AppImage and the deb, so grabbing the first .sig could pick the wrong one. Add a per-platform `updater` glob to select the right artifact (AppImage / app.tar.gz / setup.exe), and arch-suffix the macOS .app.tar.gz (+ .sig) so the two don't collide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
latest.jsoncorrectness bugs found in the v0.2.0 build:PyOps.app.tar.gz(no arch), so the second upload clobbers the first; one arch then has a signature that doesn't match the binary. Fix: arch-suffix the macOS.app.tar.gz(+.sig) — it's updater-only (users get the.dmg), so the rename is invisible.find … | head -1could grab the deb (not an updater target). Fix: a per-platformupdaterglob (AppImage / app.tar.gz / setup.exe) selects the right artifact.After merge: clear v0.2.0's assets and re-dispatch
tag=v0.2.0.