Drop Ruby < 3.1 and Rails < 7.0 support, fix Rails 8.1 router deprecation - #964
Draft
mathieujobin with Copilot wants to merge 4 commits into
Draft
Drop Ruby < 3.1 and Rails < 7.0 support, fix Rails 8.1 router deprecation#964mathieujobin with Copilot wants to merge 4 commits into
mathieujobin with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: mathieujobin <99191+mathieujobin@users.noreply.github.com>
- Remove Rails 5.2 version check in routing.rb, always use keyword args - Update gemspec to require Ruby >= 3.1 and Rails >= 7.0 - Update rubocop configuration to use plugins instead of require - Update TargetRubyVersion to 3.1 - Fix PredicateName -> PredicatePrefix in rubocop config - Regenerate rubocop_todo.yml - Bump version to 1.6.0 - Update CHANGELOG.md with breaking changes Co-authored-by: mathieujobin <99191+mathieujobin@users.noreply.github.com>
Since we now require Ruby >= 3.1, the conditional for rubocop-rspec_rails is no longer needed. Co-authored-by: mathieujobin <99191+mathieujobin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Rails 8.1 router keyword args deprecation warning
Drop Ruby < 3.1 and Rails < 7.0 support, fix Rails 8.1 router deprecation
Nov 7, 2025
ekohl
requested changes
Nov 7, 2025
ekohl
left a comment
Member
There was a problem hiding this comment.
Foreman still relies on Ruby 3.0 today and dropping that would severely hinder our ability to upgrade.
|
@mathieujobin any progress on this? |
Contributor
|
An alternative(#968) to this one only fixing the deprecation warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Rails 8.1 deprecation warning for router keyword arguments and removes support for EOL Ruby/Rails versions per issue requirements.
Changes
Router keyword args deprecation fix
lib/apipie/routing.rb, always use keyword arguments:Minimum version constraints
>= 2.6.0→>= 3.1.0>= 5.0→>= 7.0rubocop-rspec_railsdependencyRubocop modernization
plugins:instead of deprecatedrequire:for extensionsTargetRubyVersion: 2.6→3.1Naming/PredicateName→Naming/PredicatePrefix.rubocop_todo.ymlVersion bump
1.5.0→1.6.0(minor bump for breaking changes)Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.