refactor: introduce _IntrospectionRow / _IntrospectionRowWithSchema base rows - #176
Merged
Merged
Conversation
…ase rows Rename the query-row base _QueryRow to _IntrospectionRow, and add _IntrospectionRowWithSchema for the top-level rows that carry a required `schema_name`. Reparent every schema-bearing row model onto it (dropping the duplicated field) and alias the extension's schema column as schema_name so it fits the same base. Pure refactor: no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vc8vdq3jNTBHg3TfV6L7BD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the query-row base
_QueryRowto_IntrospectionRow, and add_IntrospectionRowWithSchemafor the top-level rows that carry a requiredschema_name. Reparent every schema-bearing row model onto it (dropping the duplicated field) and alias the extension's schema column asschema_nameso it fits the same base.Behavior
Pure refactor: no behavior change.
Notes
Groundwork for
--ignore-schema(#follow-up), which tells schema-bearing rows apart from dependency/global rows via the new base.