Repository navigation
Launcher feedback: languages layered, honest battery levels, GT7 check, presence statuses - #46
Merged
Merged
Conversation
…placing it A file in the Languages folder replaced the built-in file of its code whole, so every text it lacked (the home hint bar's, for a file made before them) showed in English although the launcher ships a translation. Now its texts go over the built-in ones one by one. - A regional file (de-AT) falls back to its base language (de) before English. - A file saved with a byte order mark (Windows PowerShell 5) is read instead of left out. - The focused tile's Locked badge fades a long word (Russian) instead of overflowing. - Tests: the home hint bar with such a file and with a saved language, the layering, the regional fallback, and the home screen in every bundled language.
…t a made-up percent SDL2's power levels (EMPTY, LOW, MEDIUM, FULL) were shown as 5%, 20%, 55% and 100%, so VK's Xbox One S pad read "5%" as if measured. SDL2 has no percentage (SDL_GetJoystickPowerInfo is SDL3's), so the top bar's pill, Settings > Controllers and the troubleshooter now show the level: a battery drawn with its bars and the word (Nearly empty, Low, Medium, Full). A reader that measures a percentage still shows it. - The nearly empty finding has its own text without a number, and says that some controllers report the level wrong over Bluetooth. - New texts in every language file; padBatteryAbout is gone. - Gran Turismo 7 check: a pdiWheel_0.prx that is neither an ELF nor a SELF, or an encrypted SELF, is left out and the game unlocks with the short note (tests only, no change needed).
…n and red dots Settings > AnyTogether > Show me as offers four statuses where it had Online and Appear offline. The launcher sends appearOffline and status together, so today's server still takes Invisible; one that answers without status keeps Online, with a short note for Idle and Do Not Disturb. presence.mode, /me and a friend's presence are read by their status, else as before. - Friends: idle shows a yellow moon, Do Not Disturb a red dot with a bar, invisible is offline. Their row says Idle or Do Not Disturb when they are not in a game. - The user's own dot and word on the home screen, the profile and the account rows. - New texts in every language file; presenceAppearOffline is gone.
… glass friends list
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launcher feedback from 2 November (VK, ctrl) and the presence statuses.
L1, home hints in English (VK). A file in the Languages folder replaced the built-in file of its code whole. Every text it lacked fell back to English, even where the launcher ships a translation. Now its texts go over the built-in ones one by one. A regional file (de-AT) falls back to its base language before English. A file saved with a byte order mark (PowerShell 5) is read instead of left out. The language switch itself (start in English, switch in Settings, back home; a saved language at start; the first-start picker) already worked in tests. Also fixed: the focused tile's Locked badge overflowed in Russian.
L2, "Xbox One S Controller · 5%". SDL2 gives one of four power levels, never a percentage (the call that gives one is SDL3's). The pill, Settings > Controllers and the troubleshooter now show the level: a battery drawn with its bars and a word (Nearly empty, Low, Medium, Full). A measured percentage still shows as one. New texts in every language file.
L3, Gran Turismo 7's pdiWheel_0.prx. Checked only. A module that is neither an ELF nor a SELF, or an encrypted SELF, is left out and the game unlocks with the short note. Tests added for the exact case. No code change.
Presence statuses. Settings > AnyTogether > Show me as: Online, Idle, Do Not Disturb, Invisible. The launcher sends
appearOfflineandstatustogether, so today's server still takes Invisible. Idle or Do Not Disturb on a server without them goes back to Online with a short note. Friends' idle shows a yellow moon and Do Not Disturb a red dot with a bar. A friend'sinvisibleshows as offline. A missingstatus(today's server) behaves as before. The user's own dot and word show on the home screen, the profile and the account rows.Tests: the new tests failed before the fixes (layered language file, regional fallback, home hint bar with a translator's file, home screen in every language). Goldens updated for the battery pill, the controller pages and the status dots.