Repository navigation
Discord: show the game you play and the party, with a Join button - #37
Merged
Merged
Conversation
The Mac launcher's Discord presence on Windows and Linux: the running game from when it started, the party as In a party with its size, and a Join on AnyTogether button that opens the party's join page. A game Discord knows shows as itself. Linux talks to Discord's Unix socket (runtime folder, Flatpak, Snap, temp, /tmp), Windows to its named pipe through kernel32. Settings > Behaviour gets both switches, on by default and kept per profile.
# Conflicts: # RELEASE_NOTES.md
# Conflicts: # RELEASE_NOTES.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mac launcher's Discord "Playing …" status, on Windows and Linux.
What it does:
How it talks to Discord:
Not in this PR: the Mac also offers the share play it hosts for the button. The Port's share play (now on main) has no join codes, so only the party's code counts.
Tests: frame codec, game names, the activity JSON and button limits, the join plan, the application ID, a fake Discord in memory, and a real Unix socket fake Discord (not on Windows). A UI test covers the settings rows, the party's activity and button, the switch clearing it, and a stopped code not made again.
The Windows named pipe is compiled by the Windows build here but has not been run against a real Discord.