Don't fail analyze when the PR comment can't post - #5
Merged
Conversation
A failed `--github-comment` post returned an error, so analyze exited 3 (tool failure) even when the analysis itself succeeded — masking the risk-based exit code. In CI's detached-HEAD pull_request checkout the comment post can't resolve the PR, so every dogfooding run exited 3 and the blast-radius gate blocked the PR on what was really a MEDIUM (advisory) result. The exit code is the CI contract; the comment is a side effect. Log a warning and continue, letting the risk-based exit code stand. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BcVscS2c2WCee2ZcU353bF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed
--github-commentpost made analyze exit 3 (tool failure) even when the analysis succeeded, masking the risk-based exit code. In CI's detached-HEAD pull_request checkout the comment can't resolve the PR, so every dogfooding run exited 3 and the blast-radius gate blocked the PR on what was really a MEDIUM (advisory) result. Now it logs a warning and lets the risk exit code stand.This is the fix that stops the blast-radius gate red X on PRs. Takes effect for PRs opened after it merges (pull_request workflows run from the base branch).
🤖 Generated with Claude Code