Fix empty-diff failure in the PR blast-radius gate - #3
Merged
Conversation
On a pull_request the checkout is the merge commit, so `git diff origin/<base>...HEAD` could produce an empty diff — which analyze reports as a tool failure (exit 3), failing the gate on every PR. Diff the PR's own base..head from the event SHAs instead, and treat "no changes" as a pass rather than a failure. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BcVscS2c2WCee2ZcU353bF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dogfooding gate failed on PR #2 because
git diff origin/master...HEADyields an empty diff on the merge-commit checkout, which analyze reports as exit 3 (tool failure). Diff the PR's base..head from the event SHAs instead, and treat 'no changes' as a pass.Note: pull_request workflows run the file from the base branch, so this fix takes effect for PRs opened after it merges.
🤖 Generated with Claude Code