Repository navigation
Skip the DCO check on release PRs into main - #18
Merged
Merged
Conversation
Release PRs carry the whole history, including commits from before sign-off was required, so the check always failed there. Their commits were already checked on their way into development. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D8A4w121dBr3nYoutNLaV7 Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ziad · project thread
Summary
ci.yml: thedcojob now runs only on PRs whose base is notmain(github.base_ref != 'main'). On the 1.0.0 release PR (Release 1.0.0 #16) it failed on six setup commits from before sign-off was required. Every commit reachingmainhas already been through a PR intodevelopment, where the check still runs.[Unreleased]section say so.DCO sign-off is not a required check, so the ruleset is unaffected. A skipped job shows as "skipped", not failed.
Testing
development, so its own DCO run should still execute and pass.Generated by Claude Code