Repository navigation
The results page and badge are made at every release tag - #198
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
The public results page and the Tests badge can't go stale between releases any more.
.github/workflows/release.yml. It runs when a GitHub release is published, or by hand for a tag. It checks out the tag, runsscripts/trust-report.shthere, and then runsscripts/trust-report.sh --check-release <tag>. That check fails the job unless the page is the run at that tag: the tag's own commit, the release named as the tag, and a clean tree. When the check passes, the workflow opens a PR "Test results page for vX.Y.Z" with only the page files, on top of main. The job is also red when the report itself found a problem. In that case the PR still opens, so the page shows the problem.98324c8, which is not in v0.15.0. The check reports exactly that.trust-report.shdeleted its trackeddocs/trust/logs/before readinggit status, so every run, the weekly ones included, was marked "working tree had uncommitted changes". The logs are now cleared after the tree is read.TRUST_TAGnames the release when the tagged commit carries more than one tag.tests/trust-report-test.shcovers the new behaviour. It checks the badge text, and runs--check-releaseagainst a throwaway repo: an older commit, a commit outside the tag, a "+ later commits" page, a dirty run and a missing tag are all refused. It also does a real faked run at a tag with two lightweight tags, which passes the check.Checks:
tests/trust-report-test.shpasses. Each new case fails when its rule is removed (moving the log cleanup back, ignoringTRUST_TAG, dropping the ancestry and dirty checks).STRICT=1 scripts/kit-selftest.shpasses. An independent review found the dirty-tree bug, a silentgh pr createfailure and the shared concurrency group; all three are fixed.Generated by Claude Code