Repository navigation
A new migration that only adds runs in small mode, with the database tests and one code review - #195
Merged
Merged
Conversation
…tests and one code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
scripts/risk-check.shreads a new.sqlmigration on a database risk path before it calls the change full. If every statement fits a strict allow-list in thepublicschema, the first line still saysMode: plain, followed by a+ <file>: additive migration …line and aNeeds:line. The allow-list covers:stableorimmutableSQL functions that only select and whose names the integration branch's SQL doesn't use yet;A
.sqldatabase test in a test folder counts as plain too.These stay full:
Note:line;harness/MODES.md§ Additive migration (new): small mode with the database tests in the acceptance criteria and § Check, one/code-review mediumbefore the hand-off, and the owner applying the migration through the steps file. § Choosing mode sends a+line to small mode with a plan, never light mode.harness/templates/small-plan.md§ Limit andproject/CONTROLS.md§ Risk paths name the exception.Self-test: positive cases, and about 40 must-stay-full cases, one for each bypass the reviews found.
Update note
updates/2026-11-03-additive-migrations.md(with areviewed:line) and a changelog fragment.Checks:
STRICT=1 bash scripts/kit-selftest.shpasses, with 4 fixtures and 0 problems.check-updatesandcheck-lessonsreport 0 problems. In the negative test, the old risk-check fails the new cases.Generated by Claude Code