fix(httpapi): align cluster selection cookie Secure flag with proxied HTTPS and add regression test - #83
Open
AnouarMohamed with Copilot wants to merge 1 commit into
Open
fix(httpapi): align cluster selection cookie Secure flag with proxied HTTPS and add regression test#83AnouarMohamed with Copilot wants to merge 1 commit into
AnouarMohamed with Copilot wants to merge 1 commit into
Conversation
Agent-Logs-Url: https://github.com/AnouarMohamed/KubLens-AI/sessions/8e783929-a846-4a79-a2b1-c846f6e90b62 Co-authored-by: AnouarMohamed <235483559+AnouarMohamed@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AnouarMohamed
May 13, 2026 13:09
View session
AnouarMohamed
marked this pull request as ready for review
May 13, 2026 13:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleSelectClusterto userequestIsSecure(r)instead of directr.TLS != nil.TestClusterSelectionCookieSecureWithForwardedProto) to assertSecure=truewhenX-Forwarded-Proto: httpsis present.Validation
npm run lintnpm run test:gonpm run test:webnpm run test:e2enpm run test:predictornpm run verify:releasenpm run verify:changelognpm run verify:api-contractnpm run verify:docsnpm run verify:doc-impactnpm run buildSecurity and operations impact
Securenow correctly follows proxied HTTPS viaX-Forwarded-Proto)Rollout and rollback
f8069d8to restore prior cookieSecurebehavior.