feat: normalize API error messaging across pages (#469)#716
Merged
AnnabelJoe merged 2 commits intoJul 3, 2026
Merged
Conversation
- Add src/lib/api-error.ts: parseApiError() normalises {error,code,retriable}
response shapes; apiFetch() wrapper throws human-readable error strings
- meters/page.tsx: replace inline error state with useToast pushToast()
- registerMeter/revokeMeter use apiFetch (consistent error extraction)
- onError/onSuccess push toast instead of setting local error state
- Remove redundant inline error <p> and <div role=alert> blocks
Closes AnnabelJoe#469
|
@jaydenkalu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #469
Summary
Introduces a shared
apiFetch/parseApiErrorutility so all pages surface API failures through the existing toast system rather than inconsistent inline state.Changes
src/lib/api-error.ts(new):parseApiError(body)normalises{error}and{error,code,retriable}shapes into a user-friendly string with retry guidance for transient codes;apiFetch()wrapsfetchand throws on non-okmeters/page.tsx: remove localerrorstate, useuseToast+apiFetch— register, revoke, and load errors all push a toastAcceptance criteria
retriable: true/ STELLAR codes)