Skip to content

fix: prevent welcome workflow from being skipped#305

Merged
AnkanMisra merged 1 commit into
mainfrom
fix/welcome-first-time-skip
Jul 14, 2026
Merged

fix: prevent welcome workflow from being skipped#305
AnkanMisra merged 1 commit into
mainfrom
fix/welcome-first-time-skip

Conversation

@AnkanMisra

@AnkanMisra AnkanMisra commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the duplicated job-level first-contributor condition
  • keep eligibility and duplicate-comment checks in the tested trusted script

Root cause

PR #304 is classified as FIRST_TIME_CONTRIBUTOR, but GitHub evaluated the workflow job condition as false and skipped the job before assigning a runner. Because the same condition already exists in the script, the outer gate is unnecessary and prevents the tested logic from running.

Impact

First-time contributor PRs will start the welcome job. Bots, returning contributors, and already-welcomed PRs will still be skipped safely by the script.

Verification

  • node --test .github/scripts/*.test.js
  • go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7
  • git diff --check

Note

Fix welcome workflow job to run for all contributor PRs

Removes the if condition on the welcome job in welcome-contributor.yml that restricted execution to non-bot, first-time contributors. The job now runs whenever the workflow triggers.

Macroscope summarized a2d7617.

Summary by CodeRabbit

  • Chores
    • Updated contributor welcome automation to run whenever a pull request is opened.
    • Welcome messages are no longer limited to first-time contributors or non-bot users.

Greptile Summary

This PR moves welcome eligibility checks into the trusted workflow script.

  • Removes the duplicate job-level contributor condition.
  • Keeps bot, eligibility, and duplicate-comment checks in the script.
  • Continues to run only for newly opened pull requests.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
.github/workflows/welcome-contributor.yml Removes the workflow-level eligibility gate so the trusted script makes the welcome decision.

Reviews (1): Last reviewed commit: "fix: prevent welcome workflow from being..." | Re-trigger Greptile

Context used:

  • Context used - AGENTS.md (source)
  • Context used - Prioritize correctness, security, regressions, mis... (source)

Co-authored-by: codex <codex@users.noreply.github.com>
@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
microai-paygate Ready Ready Preview, Comment Jul 14, 2026 1:35pm

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c6fde7b6-ced6-41b6-9e38-2e5e88632a72

📥 Commits

Reviewing files that changed from the base of the PR and between 2b83373 and a2d7617.

📒 Files selected for processing (1)
  • .github/workflows/welcome-contributor.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/welcome-contributor.yml

📝 Walkthrough

Walkthrough

The welcome contributor workflow removes its job-level eligibility condition, so the job runs for every pull_request_target opened event.

Changes

Welcome workflow

Layer / File(s) Summary
Remove welcome job eligibility gate
.github/workflows/welcome-contributor.yml
The welcome job no longer filters pull requests by first-time contributor association or bot status.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the workflow fix to stop the welcome job from being skipped.
Description check ✅ Passed The description covers summary, root cause, impact, and verification, though it omits several template sections like type, affected areas, and reviewer notes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/welcome-first-time-skip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added github_actions Pull requests that update GitHub Actions code type:devops Deployment, observability, operations, CI, or infrastructure work. labels Jul 14, 2026
@AnkanMisra
AnkanMisra marked this pull request as ready for review July 14, 2026 13:36
@AnkanMisra
AnkanMisra merged commit a65d772 into main Jul 14, 2026
15 checks passed
@AnkanMisra
AnkanMisra deleted the fix/welcome-first-time-skip branch July 14, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code type:devops Deployment, observability, operations, CI, or infrastructure work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant