fix: prevent welcome workflow from being skipped#305
Merged
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe welcome contributor workflow removes its job-level eligibility condition, so the job runs for every ChangesWelcome workflow
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AnkanMisra
marked this pull request as ready for review
July 14, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
PR #304 is classified as FIRST_TIME_CONTRIBUTOR, but GitHub evaluated the workflow job condition as false and skipped the job before assigning a runner. Because the same condition already exists in the script, the outer gate is unnecessary and prevents the tested logic from running.
Impact
First-time contributor PRs will start the welcome job. Bots, returning contributors, and already-welcomed PRs will still be skipped safely by the script.
Verification
Note
Fix welcome workflow job to run for all contributor PRs
Removes the
ifcondition on thewelcomejob in welcome-contributor.yml that restricted execution to non-bot, first-time contributors. The job now runs whenever the workflow triggers.Macroscope summarized a2d7617.
Summary by CodeRabbit
Greptile Summary
This PR moves welcome eligibility checks into the trusted workflow script.
Confidence Score: 5/5
This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix: prevent welcome workflow from being..." | Re-trigger Greptile
Context used: