Package complete release evidence - #83
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa2d357394
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if key == "artifact" and isinstance(value, str): | ||
| references.append(value) |
There was a problem hiding this comment.
For claims runs, negative_research is loaded from research/formats/*.json; research/formats/anyblox.json has source_commits.artifact set to a commit SHA rather than a run file. Because this recursive scan treats every nested key named artifact as a run-relative path, packaging a claims run will look for <run_dir>/3cf5008b4af5165761021b9f6f24d326d83d2a56 and fail before the benchmark workflow can upload the release archive. Limit discovery to the known manifest format entries and result artifact maps instead of arbitrary nested metadata keys.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 2d05381. Artifact discovery now reads only manifest format entries and the formal artifact/artifacts fields on benchmark observations (or their evidence object). A regression test includes negative_research.source_commits.artifact and confirms it is not treated as a run path.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d0538133e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Fixes #73
Verification: 55 tests passed. Release archives and generated reports will be regenerated from the final public commit.