fix: prevent stuck download cache renewal on error#432
Merged
Conversation
Wrap the download cache renewal logic in a try-finally block in both AnimeDownloadCache and MangaDownloadCache to ensure that the isInitializing state is always set to false, preventing the "Checking downloads" banner from remaining stuck on the screen if an exception occurs during file scanning. Close #420
There was a problem hiding this comment.
Pull request overview
Ensures the download cache “renewal” job always clears the isInitializing flag by wrapping cache scanning in try/finally, aiming to prevent the “Checking downloads” UI from getting stuck if scanning fails.
Changes:
- Wrap anime download cache renewal logic in
try/finallyto reset_isInitializing. - Wrap manga download cache renewal logic in
try/finallyto reset_isInitializing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/java/eu/kanade/tachiyomi/data/download/anime/AnimeDownloadCache.kt | Adds try/finally around cache renewal to clear initialization state on completion/failure. |
| app/src/main/java/eu/kanade/tachiyomi/data/download/manga/MangaDownloadCache.kt | Adds try/finally around cache renewal to clear initialization state on completion/failure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the download cache renewal logic in a try-finally block in both AnimeDownloadCache and MangaDownloadCache to ensure that the isInitializing state is always set to false, preventing the "Checking downloads" banner from remaining stuck on the screen if an exception occurs during file scanning.
Close #420