fix: preserve NL day-count additivity at leap-day boundaries - #76
Open
kadyrbekovhamit-cyber wants to merge 1 commit into
Open
fix: preserve NL day-count additivity at leap-day boundaries#76kadyrbekovhamit-cyber wants to merge 1 commit into
kadyrbekovhamit-cyber wants to merge 1 commit into
Conversation
Signed-off-by: kadyrbekovhamit-cyber <288885044+kadyrbekovhamit-cyber@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(d1, d2]conventionNL/365andNL/360Problem
leap_days_betweenexcluded February 29 from the end boundary, as established by the existingtest_example_2::case_4, but did not exclude it from the start boundary. Therefore:The change includes February 29 in the start-side adjustment (
ordinal() >= 60) while deliberately retaining the current end-side< 60comparison. This preserves the library's existing(d1, d2]financial interval convention.Validation
cargo test --release --features nonumpy: 227 passed, 10 ignoredcargo fmt --check