Add verify diagnostics CLI with validation tests#14
Open
MRhuang1106 wants to merge 8 commits into
Open
Conversation
Author
|
Added the requested diagnostic artifacts to PR #14: diagnostic/build-b58b0052.json and diagnostic/build-b58b0052.logd. Unit tests pass locally with python -m unittest discover -s tests. Full python build.py was attempted, but this Windows environment is missing several required toolchains, so the diagnostic files include the captured local failure output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tools/verify_diagnostics.py, a CLI for validating diagnostic JSON reports and referenced.logdartifacts before opening a PR.Changes
diagnostic/for this PR.Testing
Also attempted local diagnostic build commands on Windows:
The full build could not complete in this environment because required toolchains such as npm/cargo/git are not installed. The captured local diagnostic output is committed as:
diagnostic/build-b58b0052.jsondiagnostic/build-b58b0052.logdChecklist