[Python] Add input validation and error handling to verify_diagnostics.py#10
Open
therealsaitama0 wants to merge 2 commits into
Open
Conversation
- Add argparse CLI with --verbose, --json, --threshold flags - Wrap subprocess.run calls in try/except with meaningful error messages - Support --json output for machine consumption - Allow --threshold N for minimum passing modules (default: 0) - Validate diagnostic JSON schema on read and report structural errors - Add pytest tests for schema validation and verification logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Summary
Adds
tools/verify_diagnostics.pyto validate build diagnostic JSON artifacts with schema validation, subprocess error recovery, and machine-readable output.Changes
tools/verify_diagnostics.pyscript with:--verbose,--json,--threshold,--filetry/exceptwith meaningful error messages--jsonoutput for machine consumption--thresholdflag (default 0) for minimum passing modulestools/test_verify_diagnostics.pywith pytest coverageTesting
Run tests:
Checklist
Payment Address (Ethereum / Base USDC)
0x5e1040927a1E28D740f92De27a3d493b81682D88