Added Numpad Keybinds as bind points for the Tourbox.#49
Merged
AndyCappDev merged 2 commits intoJun 26, 2026
Conversation
AndyCappDev
requested changes
Jun 26, 2026
AndyCappDev
left a comment
AndyCappDev
left a comment
Owner
There was a problem hiding this comment.
Thanks — and you correctly identified the root cause. The GUI was capturing numpad scancodes and writing the right KEY_KP* names into the profile, but config_loader.KEY_NAMES (the parse whitelist) didn't include any of them, so they were silently dropped at parse time. Same shape of bug as #45 with KEY_MUTE.
Two things to address before merging:
- Incomplete coverage. A full numpad has 17 keys; this adds 12. Missing:
KEY_KP0(zero),KEY_KPSLASH(÷),KEY_KPASTERISK(×),KEY_KPENTER,KEY_KPEQUAL,KEY_NUMLOCK. Worth including so users don't hit the same silent-drop bug on the leftover keys. - Style consistency. The existing file generates letter/number/F-key entries programmatically (
config_loader.py:174-178); matching that pattern for KP0–KP9 keeps the file tight. Also fixes the stray spaces before:onKEY_KP5/KEY_KP6.
Suggestion inline.
Contributor
Author
|
Thank you, I had the thought that I was missing some keys in the back of my mind, I should have looked further into it. |
Fixed incomplete coverage, and matched style for adding numpad number keys. Co-authored-by: Scott Bowman <39808540+AndyCappDev@users.noreply.github.com>
CrimsonVengeance
force-pushed
the
add-numpad-keys
branch
from
1f4db0e to
97d624c
Compare
AndyCappDev
approved these changes
Jun 26, 2026
AndyCappDev
left a comment
AndyCappDev
left a comment
Owner
There was a problem hiding this comment.
Thanks for the quick turnaround — full 17-key numpad coverage looks good. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I may not see the pitfalls, so correct me if I'm wrong but I added keypad button binding to the Tourbox.