Refactor analytics consent flow and client; add Cookie banner context and catalog UI styles#76
Open
Andrey1771 wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
AnalyticsProviderand hookuseAnalyticsConsentto expose consent, banner visibility, settings state, and anupdateConsentAPI, and wired it intoTaleGameshopMainWindowwrapping the app; the provider now configuresanalyticsClient, tracks page views (excluding admin routes), and manages consent events.analyticsClientto supportconfigure,setConsent, deferredinitializewithinitializingPromise, pending page view buffering, provider availability checks viaisAnalyticsAvailable, andresetForTests; tracking and event APIs now respect consent and initialization state.analytics-consent.tswith exported types, default values, event constants,hasSavedAnalyticsConsent, and emit helpers, and addedanalytics-state.tswithisAnalyticsAvailableandshouldShowCookieBannerhelpers used by the provider.CookieBannerto use the context hook instead of local storage helpers and to callupdateConsent; improved copy and settings UI; added ARIA attributes and refactored show/hide logic.game-list-page.csscatalog classes and updated markup/classNames for toolbar, grid, cards, and result summary with pagination-aware counts and aClear filtersaction.cookie-banner.css,game-list-page.css, and footer CSS tweaks.analytics-client.test.ts,analytics-consent.test.ts,analytics-state.test.ts, and a React integration testanalytics-consent-flow.test.tsxfor the consent flow andCookieBannerinteractions.Testing
analytics-client.test.ts,analytics-consent.test.ts, andanalytics-state.test.ts, and they passed locally against the mocked DOM/script loader setup.analytics-consent-flow.test.tsxusing@testing-library/reactanduser-eventto validate the banner visibility, accept/reject behavior, initialization calls, and reopening settings, and it passed.inversify.configandanalytics-client).Codex Task