fix(release): strip stale sha256 comment from Homebrew formula - #81
Merged
Conversation
The v0.24.0 formula url/sha256 are correct (verified: the published tarball's sha256 matches). But the sha256 line carried a misleading leftover comment `# Compute from release tarball: shasum -a 256 devflow-0.1.0.tar.gz`, which read like the sha was an un-updated placeholder. Cause: release.yml's sha sed replaced only the quoted value (`s|sha256 ".*"|...|`), whose greedy `.*` stops at the closing quote and leaves any trailing comment intact. Fix both: remove the comment from the formula now, and replace the WHOLE sha256 line on every future release so it can't recur. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The v0.24.0 Homebrew formula's
url/sha256are correct — verified: the publishedv0.24.0tarball's sha256 matches the formula exactly. The only issue is a misleading leftover comment on thesha256line that reads like an un-computed placeholder:Cause
release.ymlupdates the sha withsed -i "s |sha256 \".*\"|sha256 \"${SHA}\"|". The greedy.*stops at the sha's closing quote, so it replaces only the value and leaves the trailing# …0.1.0…comment on every release.Fix
Formula/devflow.rbnow.sha256line (^([[:space:]]*)sha256 .*→ clean line) so no trailing comment can survive any future release.No functional change to installs (sha was already right); this removes the "is this a placeholder?" confusion and hardens the release pipeline.
🤖 Generated with Claude Code