fix(observability): drop container_name (no more manual web restart after boot) - #61
Merged
Merged
Conversation
…-boot restart The manual 'docker compose restart langfuse-web after boot' step existed because every service pinned a fixed container_name AND used healthcheck-based depends_on. On recreate (reboot / up), Docker renames the old container to <hash>_<name>; a dependent starting mid-rename hits 'No such container <hash>' and langfuse-web boots into a broken state (OTLP route 404, read 500) that only a manual restart cleared. Removing container_name lets Compose use stable project-scoped names (devflow-langfuse-langfuse-web-1, ...) with clean recreation and no rename race. Service DNS is unaffected (network aliases clickhouse/redis/minio + service name langfuse-web still resolve, so the OTel collector's http://langfuse-web:3000 works). Verified: full down + up (cold-boot sim) with NO manual restart -> web 200, OTLP 200, read 200, round-trip trace ingests. The manual step is gone. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR improves the reliability of the local observability stack by removing fixed container_name entries from docker/docker-compose.yml, avoiding Docker Compose’s recreate/rename race that previously left langfuse-web in a broken state after cold boots.
Changes:
- Removed
container_namefrom all services so Compose can use stable project-scoped container names. - Keeps the existing service DNS / networking model (service names + aliases) while eliminating the manual “restart langfuse-web” recovery step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
38
to
41
| # ── Hindsight (Memory) ────────────────────────────────────────────── | ||
| hindsight: | ||
| image: ghcr.io/vectorize-io/hindsight:latest | ||
| container_name: devflow-hindsight | ||
| ports: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the manual restart existed
Every langfuse service pinned a fixed
container_nameAND used healthcheckdepends_on. On recreate (reboot/up) Docker renames the old container to<hash>_<name>; a dependent starting mid-rename hitsNo such container <hash>, andlangfuse-webboots into a broken state (OTLP route 404, read 500) that only a manualdocker compose restart langfuse-webcleared.Fix
Remove
container_namefrom all services → Compose uses stable project-scoped names (devflow-langfuse-langfuse-web-1), recreation is clean, no rename race. Service DNS unaffected (network aliases + service names still resolve; collector'shttp://langfuse-web:3000works).Verified
Full
down+up -dcold-boot sim with NO manual restart → web 200, OTLP 200, read 200, round-trip trace ingests. Manual step eliminated.🤖 Generated with Claude Code