Skip to content

formatting with black - #88

Merged
AndGem merged 4 commits into
mainfrom
formatting_with_black
Oct 25, 2025
Merged

AndGem merged 4 commits into
mainfrom
formatting_with_black

Conversation

@AndGem

@AndGem AndGem commented Oct 25, 2025

Copy link
Copy Markdown
Owner

No description provided.

@code-review-doctor code-review-doctor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some food for thought. View full project report here.

Comment thread tests/integration_test.py
f = open(path)
line = f.readline()
while "#" in line:
with open(path) as f:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UnicodeDecodeError can occur if the content of the file has characters incompatible with the OS's default encoding. Python uses the OS's default text encoding on the content because encoding is not set. Explained here.

@codecov

codecov Bot commented Oct 25, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 51.61290% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.35%. Comparing base (60016cb) to head (779566a).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
osm/read_osm.py 0.00% 6 Missing ⚠️
graph/algorithms.py 0.00% 5 Missing ⚠️
osm/xml_handler.py 0.00% 5 Missing ⚠️
graph/graphfactory.py 50.00% 4 Missing ⚠️
output/write_graph.py 0.00% 3 Missing ⚠️
run.py 0.00% 3 Missing ⚠️
osm/way_parser_helper.py 0.00% 2 Missing ⚠️
graph/contract_graph.py 87.50% 1 Missing ⚠️
osm/sanitize_input.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #88       +/-   ##
===========================================
- Coverage   92.36%   55.35%   -37.01%     
===========================================
  Files          22       22               
  Lines         877      896       +19     
===========================================
- Hits          810      496      -314     
- Misses         67      400      +333     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndGem
AndGem merged commit 737d8fe into main Oct 25, 2025
2 of 4 checks passed
@AndGem
AndGem deleted the formatting_with_black branch October 25, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant