Feature/emptystate icon pool#388
Open
dominiccreates wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127 This PR introduces a visual enhancement to the empty‑state UI across the application:
Key Changes
EmptyState component
Added an optional icon?: React.ReactNode prop.
Renders the provided icon above the message with proper spacing.
Updated TypeScript typings and default export accordingly.
PoolTable
Replaced the plain text empty‑state with the new EmptyState component.
Supplies a simple SVG “plus‑cross” icon to illustrate the empty state.
Tests
Updated EmptyState.test.tsx to include a test confirming the icon renders when passed.
Adjusted existing tests to reflect the new component API.
All test suites pass with the new implementation.
Compatibility
Existing usages of EmptyState (e.g., in AnchorTable and SettlementTable) remain unchanged because the new icon prop is optional.
No changes to the public API beyond the added prop; consumers who don’t need an icon are unaffected.
Verification
Ran the full test suite (vitest) – all tests succeed.
Manual verification of the Pools page shows the empty‑state with the SVG icon correctly displayed.