feat(settlement-detail): add pending state to prevent concurrent actions#386
Open
dominiccreates wants to merge 1 commit into
Open
feat(settlement-detail): add pending state to prevent concurrent actions#386dominiccreates wants to merge 1 commit into
dominiccreates wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132 This PR adds a pending boolean state to src/components/SettlementDetail.tsx to disable Execute and Cancel buttons while an action is in flight, preventing duplicate requests. Updated the run helper to set/clear pending, added disabled={pending} to both buttons, and introduced tests verifying the disabled behavior. Also fixed wallet utilities to safely handle missing localStorage in test environments and adjusted test setup with an in‑memory localStorage shim. All tests now pass (498 total, 95% coverage).