Skip to content

Perf/memoize pools panel#349

Closed
chuks68 wants to merge 2 commits into
AnchorNet-Org:mainfrom
chuks68:perf/memoize-pools-panel
Closed

Perf/memoize pools panel#349
chuks68 wants to merge 2 commits into
AnchorNet-Org:mainfrom
chuks68:perf/memoize-pools-panel

Conversation

@chuks68

@chuks68 chuks68 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Closes #141
Summary
PoolsPanel was recomputing totalLiquidity, positions, and filteredPools using plain reduce and filter array methods on every single render. In networks with many pools, this resulted in wasted CPU cycles whenever unrelated state changes (like parent updates or keystrokes not touching the search query) occurred.

This PR wraps these calculations in useMemo with correct dependency keys (state.data and query) to avoid unnecessary recomputation.

Changes
PoolsPanel.tsx
: Wrapped totalLiquidity, positions, and filteredPools calculations in useMemo.
PoolsPanel.test.tsx
: Added a unit test spying on the matchesQuery function to verify that unrelated parent state/props re-renders do not recompute filteredPools.
Verification
Verified that rendered output is unchanged.
Confirmed that updating the search query or pool data updates the memoized values correctly.
Confirmed the new test passes and prevents regression.

@Jagadeeshftw

Copy link
Copy Markdown
Contributor

Thanks — both commits on this branch (PoolsPanel memoization, SettlementTable responsive card layout) already landed via #352. Zero net diff after merging main in, so closing as already covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memoize PoolsPanel's filteredPools computation with useMemo

2 participants