Perf/memoize pools panel#349
Closed
chuks68 wants to merge 2 commits into
Closed
Conversation
Contributor
|
Thanks — both commits on this branch (PoolsPanel memoization, SettlementTable responsive card layout) already landed via #352. Zero net diff after merging main in, so closing as already covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141
Summary
PoolsPanel was recomputing totalLiquidity, positions, and filteredPools using plain reduce and filter array methods on every single render. In networks with many pools, this resulted in wasted CPU cycles whenever unrelated state changes (like parent updates or keystrokes not touching the search query) occurred.
This PR wraps these calculations in useMemo with correct dependency keys (state.data and query) to avoid unnecessary recomputation.
Changes
PoolsPanel.tsx
: Wrapped totalLiquidity, positions, and filteredPools calculations in useMemo.
PoolsPanel.test.tsx
: Added a unit test spying on the matchesQuery function to verify that unrelated parent state/props re-renders do not recompute filteredPools.
Verification
Verified that rendered output is unchanged.
Confirmed that updating the search query or pool data updates the memoized values correctly.
Confirmed the new test passes and prevents regression.