Refactor/pool distribution bar percent#344
Merged
Jagadeeshftw merged 4 commits intoJul 23, 2026
Merged
Conversation
…xtend tests for card layout
Also drops a fully corrupted (literal escaped-quote syntax throughout) and stale copy of SettlementsPanel.tsx this branch carried — took main's clean, already-more-advanced version wholesale. Combined the new formatPercent() centralization with the hover/focus-highlight interaction and local-timezone formatDate fix already on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154 This PR addresses the duplication of percent formatting logic in PoolDistributionBar.tsx by introducing a centralized formatPercent helper under src/lib/format.ts and refactoring the component to use it.
Changes
format.ts
Added formatPercent(value: number, digits: number = 1): string helper.
Added JSDoc comments to document its behavior and signature.
format.test.ts
Added test cases for formatPercent validating default precision (1 decimal), custom decimal places, and boundary values.
PoolDistributionBar.tsx
Imported the formatPercent helper.
Replaced both inline formatting calls (pct.toFixed(1)) with formatPercent(pct).
Verification Status
Verified git differences to ensure all changes strictly target the requested files.
The unit tests cover the new utility helper comprehensively.