fix: guard wallet storage against QuotaExceededError and SecurityError#328
Merged
Jagadeeshftw merged 5 commits intoJul 23, 2026
Merged
Conversation
# Conflicts: # src/components/StatusBadge.tsx # src/lib/wallet.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard wallet.ts's localStorage calls against SecurityError/QuotaExceededError
Context
Browsers can throw synchronously from
localStorage.getItem/setItemin restricted contexts (e.g., Safari private browsing throwing aQuotaExceededError, or embedded contexts throwing aSecurityError). BecauseWalletProvidercalled these synchronous methods directly without atry/catch, it caused uncaught exceptions, entirely breaking the "Connect wallet" button and mount restore effect in those environments rather than failing gracefully.Implementation Details
window.localStorage.getItem,setItem, andremoveItemcalls insrc/lib/wallet.tswithintry/catchblocks.loadAccountreturnsnullsafely.saveAccountandclearAccountfail silently without propagating the exception.SEED_STORAGE_KEYgeneration gracefully handling storage failures.SecurityErrorandQuotaExceededErroraroundStorage.prototypeoverrides insidesrc/lib/wallet.test.ts.src/components/WalletProvider.test.tsxto verify thatWalletProviderupdates in-memory UI connection state cleanly despite the underlying local persistence failing.windowisundefined.Verification
npm test -- src/lib/wallet.test.ts src/components/WalletProvider.test.tsx).src/lib/wallet.tsandsrc/components/WalletProvider.tsxare met.closes #241