Skip to content

Set delete closed signals to 1825 days by default#1564

Open
bartjkdp wants to merge 1 commit into
Amsterdam:mainfrom
delta10:fix/change-set-delete-closed-signals
Open

Set delete closed signals to 1825 days by default#1564
bartjkdp wants to merge 1 commit into
Amsterdam:mainfrom
delta10:fix/change-set-delete-closed-signals

Conversation

@bartjkdp

Copy link
Copy Markdown
Contributor

Description

This change sets the default for delete_closed_signals to 1825 days (5 years). This is sane default as this corresponds with the policy that municipalities in The Netherlands adhere to.

With the current default it is very easy to shoot yourself in the foot. We saw 4 misconfigurations on our Signalen production environments.

Checklist

  • Keep the PR, and the amount of commits to a minimum
  • The commit messages are meaningful and descriptive
  • The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
  • Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
  • Check that the branch is based on main and is up to date with main
  • Check that the PR targets main
  • There are no merge conflicts and no conflicting Django migrations
  • PR was created with the "Allow edits and access to secrets by maintainers" checkbox checked

How has this been tested?

  • Provided unit tests that will prove the change/fix works as intended
  • Tested the change/fix locally and all unit tests still pass
  • Code coverage is at least 85% (the higher the better)
  • No iSort, Flake8 and SPDX issues are present in the code

@bartjkdp bartjkdp force-pushed the fix/change-set-delete-closed-signals branch from fb9d5fe to 5e42819 Compare January 28, 2026 19:56
@bartjkdp bartjkdp changed the title Set delete closed signals to 1825 days be default Set delete closed signals to 1825 days by default Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant