Skip to content
This repository was archived by the owner on Dec 5, 2023. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
missingDimensionStrategy 'react-native-camera', 'general'
versionCode 55
versionName "2.3.1"
versionCode 56
versionName "2.3.2"
buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()

if (isNewArchitectureEnabled()) {
Expand Down
4 changes: 2 additions & 2 deletions ios/pingpingNative.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@
CODE_SIGN_ENTITLEMENTS = pingpingNative/pingpingNative.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 55;
CURRENT_PROJECT_VERSION = 56;
DEVELOPMENT_TEAM = 39J4LQT4VN;
ENABLE_BITCODE = NO;
GCC_PREPROCESSOR_DEFINITIONS = (
Expand Down Expand Up @@ -561,7 +561,7 @@
CODE_SIGN_ENTITLEMENTS = pingpingNative/pingpingNative.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 55;
CURRENT_PROJECT_VERSION = 56;
DEVELOPMENT_TEAM = 39J4LQT4VN;
INFOPLIST_FILE = pingpingNative/Info.plist;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
Expand Down
4 changes: 2 additions & 2 deletions ios/pingpingNative/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>2.3.1</string>
<string>2.3.2</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand All @@ -34,7 +34,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>55</string>
<string>56</string>
<key>LSRequiresIPhoneOS</key>
<true />
<key>NSAppTransportSecurity</key>
Expand Down
4 changes: 2 additions & 2 deletions ios/pingpingNativeTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
<key>CFBundlePackageType</key>
<string>BNDL</string>
<key>CFBundleShortVersionString</key>
<string>2.3.1</string>
<string>2.3.2</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>55</string>
<string>56</string>
</dict>
</plist>
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "pingpingNative",
"version": "2.3.1",
"version": "2.3.2",
"private": true,
"scripts": {
"android": "react-native run-android",
Expand Down
17 changes: 6 additions & 11 deletions src/components/account/AccountBlockButton.js
Original file line number Diff line number Diff line change
@@ -1,25 +1,20 @@
import React from 'react';

import PropTypes from 'prop-types';
import {
StyleSheet,
TouchableOpacity,
} from 'react-native';
import { StyleSheet, TouchableOpacity } from 'react-native';

import theme from '../../config/theme';
import Title from '../typography/Title';

function AccountBlockButton({
button,
navigation,
}) {
function AccountBlockButton({ button, navigation }) {
return (
<TouchableOpacity
testID={button.testID}
style={styles.accountMainButton}
onPress={() =>
navigation.navigate(button.route)
}
onPress={() => navigation.navigate(button.route)}
accessibilityRole="button"
accessibilityLabel={button.title}
accessible
>
{button.image}
<Title variant="h6" align="center">
Expand Down
7 changes: 6 additions & 1 deletion src/components/header/HeaderBackButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,12 @@ import theme from '../../config/theme';

function HeaderBackButton({ onPressAction = () => {}, color = 'light' }) {
return (
<TouchableOpacity onPress={onPressAction} testID={testIDs.NAVIGATION.HEADER_BACK_BUTTON}>
<TouchableOpacity
onPress={onPressAction}
testID={testIDs.NAVIGATION.HEADER_BACK_BUTTON}
accessible
accessibilityRole="button"
>
<ArrowBackIcon color={color === 'light' ? theme.colors.white : theme.colors.text} />
</TouchableOpacity>
);
Expand Down
1 change: 1 addition & 0 deletions src/components/header/ImageOverlayHeader.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ function ImageOverlayHeader({
backgroundColor={theme.colors.headerColor}
round
testID={testIDs.NAVIGATION.HEADER_BACK_BUTTON}
accessibilityLabel="Sluiten"
/>
<CitypingsChip value={cityPings} />
</View>
Expand Down
1 change: 1 addition & 0 deletions src/components/modals/ConfirmModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ function ConfirmModal({ open = false, setOpen = () => {}, doUpdateTask = () => {
action={closeModal}
style={styles.closeButton}
iconComponent={<CloseIcon style={styles.icon} />}
accessibilityLabel="Sluiten"
/>
<Title style={styles.title}>Vragen Overslaan</Title>

Expand Down
1 change: 1 addition & 0 deletions src/components/modals/DeleteDataModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ function DeleteDataModal({
action={closeModal}
style={styles.closeButton}
iconComponent={<CloseIcon style={styles.icon} />}
accessibilityLabel="Sluiten"
/>
<Title style={styles.title}>Gegevens Verwijderen</Title>
<Body variant="b3" style={styles.body}>
Expand Down
1 change: 1 addition & 0 deletions src/components/modals/ShowRewardCodeModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ function ShowRewardCodeModal({ open = false, setOpen = () => {}, expiryDate = ''
action={closeModal}
style={styles.closeButton}
iconComponent={<CloseIcon style={styles.icon} />}
accessibilityLabel="Sluiten"
/>

<Title style={styles.title}>Jouw Code</Title>
Expand Down
1 change: 1 addition & 0 deletions src/components/modals/UpdateAppModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ function UpdateAppModal() {
action={closeModal}
style={styles.closeButton}
iconComponent={<CloseIcon style={styles.icon} />}
accessibilityLabel="Sluiten"
/>
<Title variant="h3" style={styles.title}>
Hey! Er is een nieuwe versie
Expand Down
1 change: 1 addition & 0 deletions src/components/modals/UpdateAppModal/UpdateModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ function UpdateAppModal({ closeModal, openAppStore, open }) {
action={closeModal}
style={styles.closeButton}
iconComponent={<CloseIcon style={styles.icon} />}
accessibilityLabel="Sluiten"
/>
<Title variant="h3" style={styles.title}>
Hey! Er is een nieuwe versie
Expand Down
3 changes: 3 additions & 0 deletions src/components/onboarding/AnswerButtonOnboarding.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ function AnswerButtonOnboarding({
style={[styles.button, active && styles.activeButton]}
variant="outline"
onPress={onPress}
accessibilityRole="button"
accessibilityLabel={label}
accessible
>
<Text style={[styles.label, active && styles.activeText]}>{label}</Text>
</TouchableOpacity>
Expand Down
3 changes: 3 additions & 0 deletions src/components/onboarding/NextButtonQuestionScreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ function NextButtonQuestionScreen({ nextButtonDisabled, submitAnswer }) {
variant="text"
disabled={nextButtonDisabled}
style={styles.nextButton}
accessible
accessibilityState={{ disabled: nextButtonDisabled }}
accessibilityRole="button"
>
<Text
style={[
Expand Down
2 changes: 1 addition & 1 deletion src/components/onboarding/OnboardingPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function OnboardingItem({ pageContent: { svg, title, text } }) {

return (
<View style={styles.viewContainer}>
<View>
<View accessibilityRole="image">
<SvgIllustration />
</View>
<View>
Expand Down
2 changes: 2 additions & 0 deletions src/components/onboarding/questionTypes/DateOfBirth.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ function DateOfBirth({
day: itemValue,
})
}
accessible
accessibilityLabel="Kies een dag"
>
<Picker.Item label="Dag" value="" />
{getDays()}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,20 @@ function InputComponent({
onBlur={onBlur}
style={styles.input}
/>
<TouchableOpacity style={styles.clearButton} onPress={onClearPress}>
<TouchableOpacity
style={styles.clearButton}
onPress={onClearPress}
accessible
accessibilityRole="button"
>
{!!searchText && <CloseIcon />}
</TouchableOpacity>
<TouchableOpacity style={styles.chevronButton} onPress={toggle}>
<TouchableOpacity
style={styles.chevronButton}
onPress={toggle}
accessible
accessibilityRole="button"
>
{isOpened ? <ChevronUpIcon /> : <ChevronDownIcon />}
</TouchableOpacity>
</View>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ function DropDownSelect({
onPress={() => doUpdateTask()}
disabled={!selectedItem.value}
label="Volgende"
accessible
accessibilityRole="button"
accessibilityState={{ disabled: true }}
/>
</View>
</View>
Expand Down
59 changes: 13 additions & 46 deletions src/components/route/RouteTaskRow.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
import React, { memo } from 'react';

import PropTypes from 'prop-types';
import {
StyleSheet,
TouchableOpacity,
View,
} from 'react-native';
import { StyleSheet, TouchableOpacity, View } from 'react-native';
import { View as AnimatableView } from 'react-native-animatable';

import routes from '../../App/stacks/routes';
Expand All @@ -15,64 +11,36 @@ import Title from '../typography/Title';

const CIRCLE_RADIUS = 30;

function RouteTaskRow({
task: { task, status },
index,
navigation,
routeId,
tasksToDo,
}) {
function RouteTaskRow({ task: { task, status }, index, navigation, routeId, tasksToDo }) {
const isCompleted = status === 'Completed';
const isCurrentTask =
tasksToDo.length > 0 &&
tasksToDo[0].task.taskId === task.taskId;
const isCurrentTask = tasksToDo.length > 0 && tasksToDo[0].task.taskId === task.taskId;

const doNavigate = () => {
navigation.navigate(
routes.routeStack.screens.taskScreen,
{
routeId,
task: { ...task, status },
},
);
navigation.navigate(routes.routeStack.screens.taskScreen, {
routeId,
task: { ...task, status },
});
};

return (
<TouchableOpacity onPress={doNavigate}>
<View
style={[
styles.container,
index % 2 === 0 && styles.background,
]}
>
<TouchableOpacity onPress={doNavigate} accessible accessibilityRole="button">
<View style={[styles.container, index % 2 === 0 && styles.background]}>
<View
style={[
styles.circleStepIndicator,
isCurrentTask && styles.circleActive,
isCompleted && styles.circleDisabled,
]}
>
<Title
variant="h6"
style={styles.label}
>
<Title variant="h6" style={styles.label}>
{index}
</Title>
</View>
<Title
style={[
styles.title,
isCompleted && styles.disabled,
]}
variant="h5"
>
<Title style={[styles.title, isCompleted && styles.disabled]} variant="h5">
{task.title}
</Title>
{isCompleted && (
<AnimatableView
animation="bounceIn"
delay={200}
>
<AnimatableView animation="bounceIn" delay={200}>
<Badge style={styles.badge} />
</AnimatableView>
)}
Expand Down Expand Up @@ -118,8 +86,7 @@ const styles = StyleSheet.create({
marginLeft: theme.spacing.xxs,
},
background: {
backgroundColor:
theme.colors.taskRowBackground,
backgroundColor: theme.colors.taskRowBackground,
},
});

Expand Down
16 changes: 6 additions & 10 deletions src/components/route/TipsChip.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import React from 'react';

import PropTypes from 'prop-types';
import {
StyleSheet,
TouchableOpacity,
} from 'react-native';
import { StyleSheet, TouchableOpacity } from 'react-native';

import routes from '../../App/stacks/routes';
import LightBulb from '../../assets/svg/icons/LightBulb';
Expand All @@ -16,13 +13,12 @@ function TipsChip({ navigation, tips }) {
<TouchableOpacity
style={styles.container}
onPress={() =>
navigation.navigate(
routes.routeStack.screens.tipScreen,
{
tips,
},
)
navigation.navigate(routes.routeStack.screens.tipScreen, {
tips,
})
}
accessible
accessibilityRole="button"
>
<LightBulb />
<Title style={styles.title} variant="h5">
Expand Down
9 changes: 8 additions & 1 deletion src/components/shared/Card.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,14 @@ function Card({
}) {
return (
<View style={[styles.paper, !disabled && styles.paperShadow, style]} testID={testID}>
<TouchableOpacity onPress={onPress}>
<TouchableOpacity
onPress={onPress}
accessibilityRole="button"
accessibilityLabel={`${
disabled ? 'Deze route is nog niet beschikbaar' : 'Route card'
}`}
accessibilityState={{ disabled }}
>
<View>
<View style={styles.imageContainer}>
<ProgressiveImage
Expand Down
Loading