This repository was archived by the owner on Nov 7, 2025. It is now read-only.
fix: Return only one response for each request#15
Draft
TerryvanWalen wants to merge 1 commit into
Draft
Conversation
TerryvanWalen
commented
Jun 21, 2024
Comment on lines
+297
to
304
| try { | ||
| await fetchAllSites(req, res); | ||
| } catch (e) { | ||
| console.error('An error occurred fetching the site config:', e); | ||
| if (res) return res.status(500).json({error: 'An error occured fetching the sites data: ' + e}); | ||
| } | ||
| req.forceRestart = true; | ||
| next(); |
Author
There was a problem hiding this comment.
We have to do an early return because we can only return one response to each request. Is the req.forceRestart doing something important?
The next() loads the next middleware, that middleware can emit another response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve the 2870 errors we received last week: