Add Logging Proxy for AuthRepository with Koin Integration - #108
Open
NadaMJARRAH wants to merge 2 commits into
Open
Add Logging Proxy for AuthRepository with Koin Integration#108NadaMJARRAH wants to merge 2 commits into
NadaMJARRAH wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves system observability and debuggability by logging authentication events. It keeps the separation of concerns clean by using the Proxy Pattern instead of bloating use cases with logging logic.
This is what we did in this PR:
AuthRepositoryLoggingProxyto wrap the originalAuthRepositoryImplimplementation.loginandcreateUseroperations to log authentication-related events usingLogRepository.single<AuthRepository>binding to inject the proxy instead of the raw implementation.