Support forced photometry#60
Open
jvansanten wants to merge 12 commits into
Open
Conversation
- Import forced-photometry history verbatim in ZiAlertSupplier - Treat flux > 5*fluxunc like a "detection" in alert photometry
This allows ZiDataPointShaper to tag candidate photometry to distinguish it from prv_candidate (differential) photometry, which in turn allows ZiMongerMuxer to use candidate photometry from a previous alert.
for better uniformity than blake2. This is more important than irreversibility.
Member
|
vbrinnel
force-pushed
the
master
branch
8 times, most recently
from
April 7, 2023 13:43
3d777ae to
d80233a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZTF forced photometry is coming (at some point), and will mean three different kinds of datapoints:
Of these, only alert photometry will come with unique ids (
candid), making the previous convention for identifying datapoints (positive ids forcandid, negative for a synthesized upper limit id) unsustainable. To better support data without unique ids, make the following changes:candidate, to distinguish full differential photometry from the partial information supplied with legacy alert history.ZTF_ALERTfor a point fromcandidate,ZTF_DPfor differential photometry,ZTF_ULfor upper limit,ZTF_FPfor forced photometry)ZTF_ALERT. This effectively reproduces the previous behavior, where attempts to insert a differential history point would instead update the alert point with the samecandid.