M2.4.6/privacy tier consolidation - #82
Open
AashishH15 wants to merge 9 commits into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
- resolve_vault_effective_privacy defaulting NULL to "open" - Audited every single call site of getVaultDisplayPath across the ui/ codebase - Tauri availability detection - Added an explicit comment (// "locked" is preserved as a defensive fallback for legacy unmigrated data, mapping to rank 2 (redacted).) and added a dedicated unit test
…ated component test infrastructure
…ub_vault_id / next_sub_vault_id instead of hardcoded None::<String>. - Added an else branch in the chat compaction eviction loop to record assistant responses when an evicted history slice starts with an assistant message. - Replaced void chatClearEphemeralSession(id) with a try/catch block that awaits chatClearEphemeralSession(id). - Retained LEFT JOIN sub_vaults sv ON sv.id = n.sub_vault_id alongside LEFT JOIN vaults v ON v.id = n.vault_id for assembler query tier resolution. - Enforced exact should_bypass_retrieval contract (total_tokens <= 1500 || total_chunks <= 3). - Refactored normalize_tier to use eq_ignore_ascii_case instead of allocating heap Strings via to_lowercase(). - Kept ONNX runtime sessions safely scoped per-call to avoid static DLL teardown STATUS_ACCESS_VIOLATION issues across multithreaded test runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went from 4-tier privacy since "locked" and "local" were sort of the same and "redacted" did the "locking."
Cut out locked and now it's open, local, and redacted.