[Draft] eckbuilder search UX: smarter defaults, format-aware legality, Unique discoverability

[gjuillot]

Summary

Screenshots below

A batch of UX improvements to the card search panel while editing a deck. Everything is scoped to deckbuilder mode only ($_csMode === 'deck' / MODE === 'deck') — the shared Cards page keeps its existing behavior unless explicitly noted.

• Faction quick-filter buttons moved into "Advanced search"; the hero's faction is auto-selected on load and re-synced live when the hero changes.
• Search now runs automatically on load instead of showing an empty state until "Search" is clicked.
• Hero and Token removed from the type filter row (neither is a real search target: the hero has its own picker, tokens aren't deckbuilder-legal).
• Rarity and type filters now share one line — rarity left, type right, with the separator centered in whatever gap remains between them.
• All deck-relevant types (Character, Spell, Landmark Permanent, Expedition Permanent) are preselected by default; Mana is not.
• "Reset" restores the hero's faction and the default type set instead of clearing them.
• Cards banned/suspended by the deck's current format are now hidden by default (format legality read from data/altered.json), and reappear when the format allows them (Sandbox, Test). The "Banned"/"Suspended" advanced-search buttons switch from isolating-only to an "include anyway" override in deck mode, with a tooltip explaining why they're greyed out when the format already allows everything.
• Fixed a bug (introduced while building the above): toggling "Banned"/"Suspended" was inheriting the Cards-page's "drop the rarity restriction" isolate behavior, which let unrelated Unique-rarity cards flood the results.
• Removed "Errated" and "No effect" from the deckbuilder's status filters — arguably out of scope there (open to disagreement).
• Cards page: added a small gold-accented nudge ("Looking for a Unique? → Uniques tab") shown whenever Unique is toggled on "Toutes les cartes"/"All cards", since that tab's plain rarity filter misses the dedicated Uniques tab's format/effect/support-effect search. Applies to both the Cards page and the deckbuilder.
• Uniques tab now adapts to the deck's format:
  • Shows an orange warning banner when the format doesn't allow any Unique cards at all (maxUnique === 0, e.g. Standard No Unique, Singleton No Unique).
  • Preselects the "Frontier" format filter when the deck's format is Frontier.
  • Both re-apply live when the format changes and are restored by "Reset" (Frontier stays selected instead of reverting to "All Uniques").
• Consolidated the "Looking for a Unique?" nudge and the new format warning into a single banner component that swaps between gold (nudge) and orange (warning) depending on tab + format legality, and moved it to sit right under the tab list instead of further down in the filters.

Screenshots

Display right after clicking Modify

Suspended and banned cards not shown by default

Sandbox does not filter out banned or suspended

Nudge message when a user is tempted to use the unique filter on the "All cards" tab*

Nudge message when the user is tempted to search uniques in No uniques format

Frontier is auto-selected in Uniques tab

Discussion / follow-up (not implemented, needs a team decision)

While fixing the rarity-widening bug above, we found the Cards page's isolate behavior for Banned/Suspended/Errated has the same quirk baked in on purpose (dropping the rarity restriction so "browse all banned cards" isn't accidentally scoped to only Common/Rare/Exalted). Worth discussing whether that's still the right call there too, or should be tightened the same way as deck mode. Left a TODO(discuss with team) comment at the relevant _statusActive check in card-search.js.

Ramaining work

• Fix bug when leaving All Cards tab for another then back to All Cards: the preselection of types is lost
• Other tabs gut Uniques should have the same pre-selected types

Test plan

• Open the deckbuilder for an existing deck: confirm the hero's faction and default types are preselected, and results load without clicking Search
• Change hero mid-session: faction filter updates live
• Click Reset: hero faction + default types come back (not cleared)
• Switch deck format between Standard and Sandbox: banned/suspended cards hide/show accordingly, without a manual re-search
• Toggle "Banned"/"Suspended" when the format disallows them: cards reappear without dragging in unrelated Uniques
• Toggle Unique on "All cards" (deckbuilder and Cards page): nudge appears, gold-accented, linking to the Uniques tab
• Cards page: confirm Banned/Suspended/Errated/No-effect filters and the faction quick-filter bar are all unchanged
• Switch deck format to one with maxUnique: 0 (e.g. Standard No Unique): orange banner appears on both "All cards" (with Unique toggled) and the Uniques tab; disappears when switching to a format that allows Uniques
• Switch deck format to Frontier: Uniques tab preselects "Frontier"; clicking Reset keeps it selected instead of reverting to "All Uniques"