[Draft] Deckbuilder: create decks through a dedicated dialog, with a reworked hero picker

[gjuillot]

Problem

Creating a deck drops the user straight into the full builder. Card search fills most
of the screen, and the deck's own fields — hero, name, format, visibility — sit in a
side panel that people don't notice. Decks end up saved under the "Unnamed" fallback,
in whatever format happened to be selected.

The hero picker compounds it. It lists every printing of every hero as a separate
unlabelled tile, in the order the API returns them, so a hero reprinted across sets
appears several times, scattered through the grid.

Creation dialog

A new deck now opens on a dialog that asks for what the deck needs before the builder
appears: hero, name, format, visibility, and an optional description folded away behind
a toggle. Nothing is preselected except visibility, which defaults to private.

The dialog is entered whenever a builder URL carries no ?id=, which covers every
entry point — deck list, empty state, guest button, direct URL, bookmark. The ?id=
paths (edit, duplicate, import) are untouched.

The hero is a field of this form: clicking it opens the picker as a sub-dialog, and the
row then shows the hero's artwork, name and faction, with the faction colour echoing
the picker's faction buttons. Each format carries a one-line descriptor derived from the
rules in altered.json rather than hardcoded copy, so the two cannot drift apart:

Format	Descriptor
Standard All Uniques	39 to 59 cards · up to 3 uniques
Frontier	39 to 59 cards · Frontier-legal uniques only
Standard No Unique	39 to 59 cards · no unique cards
Singleton	59 to 79 cards · 1 copy per card · up to 3 uniques
Singleton No Unique	59 to 79 cards · 1 copy per card · no unique cards
Sandbox	4 to 100 cards · no restrictions

The deck is created when the form is submitted, not before: the dialog writes into the
right-hand panel's controls, which stay the single source of truth for saving, and
autosave is held back until then. Closing is deliberate only — the close button and
Cancel, never a click on the backdrop, since leaving means abandoning the deck.

Hero picker

Printings are grouped by hero identity, so the grid holds one named tile per hero, and
the printing that lands on the deck is chosen deterministically. Browsing is per
faction, Axiom first, with the faction tiles taking the official colours from
altered.json.

Board Game Arena availability

Some sets are absent from Board Game Arena, so some heroes cannot be played there, and
formats will start banning whole sets as rotations land. Those decks stay buildable —
theory crafting is deliberate — but the dialog says so before the deck exists.

Formats and sets both carry a bgalegal flag; formats also accept a bannedSets list,
inert while empty. A hero counts as available in a format when at least one of its
printings comes from a set that is both on BGA and allowed there, giving three hero
states: available in every BGA format, in some, or in none.

The format list resolves this per row, most blocking first:

Condition	Pill	Colour
Format not run on BGA	BGA - Format unavailable	light red
Hero unusable in this format	BGA - Hero unavailable	orange
Otherwise	BGA - Available	green

Light red is reserved for the format level, the one refusal a user cannot work around
without changing format; orange marks what a different hero fixes. In the picker, a hero
unusable everywhere is flagged orange on its tile and one usable in only some formats
yellow, so the constraint is visible before the hero is even chosen.

BGA Arena format

Board Game Arena runs its competitive Arena queue on one format at a time — Frontier
today. The dialog flags it, so a player building for competitive play does not have to
look it up elsewhere. The pointer lives at the root of altered.json rather than on a
format, since it is a single global choice that moves on BGA's schedule: keeping it
unique makes two flagged formats impossible, and the admin JSON editor can correct it
without a deploy.

The badge takes a colour of its own, outside the availability scale — it answers "is
this the competitive format right now", not "can I play this on BGA" — and suppresses
the redundant green pill on that row, while still letting a warning through.

Formats are ordered for the reader rather than following the reference data: Arena
first, then the other BGA formats, then the unrestricted ones, then the rest, each group
alphabetical on the displayed name.

Latest-set heroes were unreachable

default_heroes.sets was stale: the main sets EOLE and FUGUE were missing from it.
Six heroes — one per faction, including Sierra Navigatrice — did not appear in the
deckbuilder at all. Not a missing-artwork issue but missing content. Both sets are now
in the list.

Also fixed

• grid-template-columns: repeat(n, 1fr) resolves its auto minimum to each card
  image's intrinsic width (~630px), which forced a single column. Now minmax(0, 1fr).
• Picking a hero marks the deck dirty, which armed the 5-second autosave timer and
  created the deck under the "Unnamed" fallback while the form was still being filled.

Known limitation

The hero banner in the right-hand panel does not reflect the printing stored on the
deck. It uses a dedicated wide-crop asset that the CDN does not have for promos, nor for
some BISE printings, hence a protective normalisation of the reference. Fixable with a
preload fallback chain; out of scope here.

Testing

No test suite covers this area. Verified by hand against the local development stack
with the real Keycloak and decks-api: creating a deck through the dialog, cancelling,
reopening the picker from an existing deck, and the BGA verdicts across all three hero
states. Hero grouping and availability were checked against live Cards API responses for
all six factions — 9 heroes unusable on BGA out of 36. Format ordering and descriptors
were verified against altered.json. PHP and JavaScript both pass syntax checks.

Set rotation itself is not shipped: bannedSets is empty everywhere, so the
format-dependent (yellow) state cannot occur in production yet. It was exercised locally
by filling that list, which is how the screenshots showing it were produced.